You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@yunikorn.apache.org by "Weiwei Yang (Jira)" <ji...@apache.org> on 2021/08/05 04:18:00 UTC
[jira] [Resolved] (YUNIKORN-771) make license-check passes always
on linux
[ https://issues.apache.org/jira/browse/YUNIKORN-771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Weiwei Yang resolved YUNIKORN-771.
----------------------------------
Fix Version/s: 1.0.0
Resolution: Fixed
> make license-check passes always on linux
> -----------------------------------------
>
> Key: YUNIKORN-771
> URL: https://issues.apache.org/jira/browse/YUNIKORN-771
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: build
> Reporter: Wilfred Spiegelenburg
> Assignee: Wilfred Spiegelenburg
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.0
>
>
> The {{make license-check}} always passes when run on linux.
> The recursive grep that is used never writes out any file information when redirected as part of the make. When run directly from the terminal the command works as expected.
> The command works without a problem when run as part of a make on MacOSX.
> The github action that is part of the PR workflow runs on linux. That means we never catch a missing license for a file during the PR review unless we see it by inspection.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org