You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "nafiyAix (via GitHub)" <gi...@apache.org> on 2023/03/01 10:44:13 UTC
[GitHub] [incubator-celeborn] nafiyAix commented on a diff in pull request #1283: [CELEBORN-336] Revive Failed should use keep the corresponding StatusCode
nafiyAix commented on code in PR #1283:
URL: https://github.com/apache/incubator-celeborn/pull/1283#discussion_r1121330277
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -194,7 +194,8 @@ private void submitRetryPushData(
int partitionId = loc.getId();
if (!revive(
applicationId, shuffleId, mapId, attemptId, partitionId, loc.getEpoch(), loc, cause)) {
- wrappedCallback.onFailure(new CelebornIOException(StatusCode.REVIVE_FAILED));
+ wrappedCallback.onFailure(
+ new CelebornIOException(cause + " then " + StatusCode.REVIVE_FAILED));
Review Comment:
Could we add more information to describe what happen in the log? Currently using a then seems a bit simple and it is not easy to understand the scenario from log
##########
client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java:
##########
@@ -276,7 +277,10 @@ private void submitRetryPushMergedData(
String.format(
"Revive failed while pushing merged for shuffle %d map %d attempt %d partition %d batch %d location %s.",
shuffleId, mapId, attemptId, partitionId, oldGroupedBatchId, batch.loc);
- pushState.exception.compareAndSet(null, new CelebornIOException(errorMsg));
+ pushState.exception.compareAndSet(
+ null,
+ new CelebornIOException(
+ errorMsg, new CelebornIOException(cause + " then " + StatusCode.REVIVE_FAILED)));
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org