[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

[GitBox <gi...@apache.org>]

bruno-roustant commented on a change in pull request #2166:
URL: https://github.com/apache/lucene-solr/pull/2166#discussion_r552606223



##########
File path: solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java
##########
@@ -405,11 +398,6 @@ public void incRef(Directory directory) {
 
   @Override
   public void init(@SuppressWarnings("rawtypes") NamedList args) {
-    maxWriteMBPerSecFlush = (Double) args.get("maxWriteMBPerSecFlush");
-    maxWriteMBPerSecMerge = (Double) args.get("maxWriteMBPerSecMerge");
-    maxWriteMBPerSecRead = (Double) args.get("maxWriteMBPerSecRead");
-    maxWriteMBPerSecDefault = (Double) args.get("maxWriteMBPerSecDefault");
-

Review comment:
       I simply noticed that those fields were private and actually never used. I think they should be removed for clarity, but that's not necessary for this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org