You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2016/09/23 00:29:37 UTC

[Impala-ASF-CR] IMPALA-4193: Improve detection of max CPU frequency

Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/4521

Change subject: IMPALA-4193: Improve detection of max CPU frequency
......................................................................

IMPALA-4193: Improve detection of max CPU frequency

The current method of determining the maximum CPU frequency looks at
/proc/cpuinfo during startup and finds the maximum value for any CPU. If
the system is not under load during startup, this value can be lower
than the actual value. Especially in performance micro benchmarks this
can affect the accuracy of the measurements.

This change tries to read the maximum frequency from
/sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_max_freq instead and falls
back to the old method.

I tested this on my local system and it works. However I don't know how
to write a proper test for this, suggestions welcome.

Change-Id: I4f1d9023f78691f076c6fb71ce1a19294086e3fe
---
M be/src/util/cpu-info.cc
1 file changed, 13 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/4521/1
-- 
To view, visit http://gerrit.cloudera.org:8080/4521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f1d9023f78691f076c6fb71ce1a19294086e3fe
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>

[Impala-ASF-CR] IMPALA-4193: Improve detection of max CPU frequency

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has abandoned this change.

Change subject: IMPALA-4193: Improve detection of max CPU frequency
......................................................................


Abandoned

This was addressed in https://gerrit.cloudera.org/4528

-- 
To view, visit http://gerrit.cloudera.org:8080/4521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4f1d9023f78691f076c6fb71ce1a19294086e3fe
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>