You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/20 22:54:30 UTC
[GitHub] [camel-website] Gunkev opened a new pull request #247: centered
navbar correctly
Gunkev opened a new pull request #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247
In this PR I centered the elements vertically in the navigation bar
# Original camel website navbar
# Camel navbar after changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #247: centered navbar
correctly
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247#issuecomment-603165573
I don't think this is the right approach. I think we should close this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #247: centered navbar
correctly
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247#issuecomment-603164229
Preview is [here](https://builds.apache.org/job/Camel.website/job/PR-247/Preview/index.html).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] djencks commented on issue #247: centered navbar
correctly
Posted by GitBox <gi...@apache.org>.
djencks commented on issue #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247#issuecomment-601949685
Personally I prefer the unmodified proportions. They are closer to the golden ratio. In addition, to me it seems that the word "Camel" on the left, being the largest and heaviest visual element, defines where the line is; the unmodified version continues on that line, more or less, while the modified version floats up and doesn't relate to the beginning of the line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#247: centered navbar correctly
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247#discussion_r397056895
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -253,7 +255,7 @@ body {
.navbar-item,
.navbar-link {
align-items: flex-end;
- display: flex;
+ display: block;
Review comment:
I'm pretty sure that changing this to block from flex breaks something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #247: centered navbar
correctly
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#247: centered navbar correctly
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247#discussion_r397057047
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -45,6 +46,7 @@ body {
.navbar-end .navbar-link::after {
border-color: var(--navbar-font-color);
+ margin-top: -6px;
Review comment:
I'd prefer not to use tricks like negative margins.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#247: centered navbar correctly
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #247: centered navbar correctly
URL: https://github.com/apache/camel-website/pull/247#discussion_r397057400
##########
File path: antora-ui-camel/src/css/header.css
##########
@@ -35,6 +35,7 @@ body {
.navbar-end > .navbar-item,
.navbar-end .navbar-link {
color: var(--navbar-font-color);
+ line-height: 55px;
Review comment:
We prefer not to use px but rather rem as the font size can be changed by the user using the browsers zoom in-out feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services