You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2023/04/19 09:26:39 UTC

[GitHub] [skywalking] wankai123 opened a new pull request, #10704: UI templates: Simplify metric name with the label.

wankai123 opened a new pull request, #10704:
URL: https://github.com/apache/skywalking/pull/10704

   Include: general, mesh, self-observe, browser,k8s, linux 
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng commented on a diff in pull request #10704: UI templates: Simplify metric name with the label.

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #10704:
URL: https://github.com/apache/skywalking/pull/10704#discussion_r1171077233


##########
docs/en/changes/changes.md:
##########
@@ -52,6 +52,7 @@
 * Add elasticsearch menu.
 * [Clean UI templates before upgrade] Set `showSymbol: true`, and make the data point shows on the Line graph.
   Please clean `ui_template` index in elasticsearch storage or table in JDBC storage.
+* UI templates: Simplify metric name with the label.

Review Comment:
   ```suggestion
   * [Clean UI templates before upgrade] UI templates: Simplify metric name with the label.
   ```
   
   I think this should follow the same log format as the previous one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [skywalking] wu-sheng merged pull request #10704: UI templates: Simplify metric name with the label.

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #10704:
URL: https://github.com/apache/skywalking/pull/10704


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org