You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/29 16:54:32 UTC
[GitHub] [iceberg] kbendick opened a new pull request #1692: Change labeler to run on the more secure pull_request_target
kbendick opened a new pull request #1692:
URL: https://github.com/apache/iceberg/pull/1692
The labeler worked in my fork, but not when I pushed a change to this repo. On further inspection, it seems that the target of the workflow needs to be on `pull_request_target`, so that people who don't have push / write access to the repo can still trigger the workflow.
I found this here: https://github.com/actions/labeler/issues/12
I also need to verify the permissions with ASF infra for `Fork Pull Request Workflows` to ensure that nobody can gain easy access to our secrets (I assume they likely have it set up correctly already, but since this is our first foray into the land of official github workflows, it's likely best to double check).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1692: Change labeler to run on the more secure pull_request_target
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1692:
URL: https://github.com/apache/iceberg/pull/1692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #1692: Change labeler to run on the more secure pull_request_target
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #1692:
URL: https://github.com/apache/iceberg/pull/1692#issuecomment-718893623
I've opened a ticket with ASF Infra to ensure the repo's permissions are correct: https://issues.apache.org/jira/browse/INFRA-21052, but we'll also need to enable this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org