You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/11/14 17:23:27 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #3549: Spark: Split SparkCatalogTestBase and allow running tests with one catalog

rdblue commented on a change in pull request #3549:
URL: https://github.com/apache/iceberg/pull/3549#discussion_r748884012



##########
File path: spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/SparkRowLevelOperationsTestBase.java
##########
@@ -69,34 +70,34 @@ public SparkRowLevelOperationsTestBase(String catalogName, String implementation
       " format = {3}, vectorized = {4}, distributionMode = {5}")
   public static Object[][] parameters() {
     return new Object[][] {
-        { "testhive", SparkCatalog.class.getName(),
-            ImmutableMap.of(
-                "type", "hive",
-                "default-namespace", "default"
-            ),
-            "orc",
-            true,
-            WRITE_DISTRIBUTION_MODE_NONE
+        {"testhive", SparkCatalog.class.getName(),
+         ImmutableMap.of(
+             "type", "hive",
+             "default-namespace", "default"
+         ),
+         "orc",
+         true,
+         WRITE_DISTRIBUTION_MODE_NONE

Review comment:
       Please remove all unnecessary formatting changes so that we can see just what changed. Thanks!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org