You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "smjn (via GitHub)" <gi...@apache.org> on 2026/04/08 08:58:39 UTC

[PR] KAFKA-20415: Add share.version=2 for gated DLQ support. [kafka]

smjn opened a new pull request, #21994:
URL: https://github.com/apache/kafka/pull/21994

   * DLQ support for share groups KIP-1191 will be gated by a `share.version` upgrade - slated for 4.4
   * In this PR, we have added the appropriate changes and updated tests in `FeatureCommandTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20415: Add share.version=2 for gated DLQ support. [kafka]

Posted by "smjn (via GitHub)" <gi...@apache.org>.
smjn commented on PR #21994:
URL: https://github.com/apache/kafka/pull/21994#issuecomment-4205059440

   ### Sampl o/p
   broker
   ```
   [2026-04-08 14:22:32,417] INFO [ControllerServer id=1] Loaded new metadata FinalizedFeatures[metadataVersion=4.4-IV0, finalizedFeatures={group.version=1, streams.version=1, transaction.version=2, eligible.leader.replicas.version=1, share.version=2, metadata.version=31}, finalizedFeaturesEpoch=1359]. (org.apache.kafka.metadata.publisher.FeaturesPublisher)
   ```
   
   client
   ```
   $ bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --feature share.version=2
   share.version was upgraded to 2.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20415: Add share.version=2 for gated DLQ support. [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #21994:
URL: https://github.com/apache/kafka/pull/21994


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] KAFKA-20415: Add share.version=2 for gated DLQ support. [kafka]

Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #21994:
URL: https://github.com/apache/kafka/pull/21994#discussion_r3050494134


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -130,6 +130,9 @@ public enum MetadataVersion {
     // they have set the configuration unstable.feature.versions.enable=true.
     // Please move this comment when updating the LATEST_PRODUCTION constant.
     //
+
+    // IBP_4_4_IV0 enables dead-letter queue support for share groups. When this version

Review Comment:
   Let's put the KIP number in the comment too for cross-referencing. I often find it useful to see where features were introduced in order to go back and see the specification.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org