You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by christoph-k86 <gi...@git.apache.org> on 2016/02/20 10:51:52 UTC
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
GitHub user christoph-k86 opened a pull request:
https://github.com/apache/trafficserver/pull/490
TS-4048: Broken Vagrantfile in a lot of ways
- removed some broken boxes
- added some boxes
- changed from puppet-provisioning to shell-provisioning
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/christoph-k86/trafficserver TS-4048
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #490
----
commit 475bc4d408fb4182d371613a8459bcba5b832a4d
Author: Christoph Keller <ke...@gmail.com>
Date: 2016-02-19T21:40:25Z
removed a lot of broken stuff
commit 16b134ab9f528bcfbf5350c2f9f813bfd0f0d12b
Author: Christoph Keller <ke...@gmail.com>
Date: 2016-02-19T23:13:51Z
added omnios and forced updates of packagelists
commit cf3c7c7e81899ed45cd45621d946ef2d5d207f51
Author: Christoph Keller <ke...@gmail.com>
Date: 2016-02-19T23:15:03Z
added OmniOS, speed up vm's with more cores and switch jessie image to one with guest additions
commit 856cf2bc9244de53ba23dac0b91df496006b197d
Author: Christoph Keller <ke...@gmail.com>
Date: 2016-02-20T08:37:25Z
we don't need thos puppet-files anymore because we use a shell provisioner
commit 3879d2c1f116ad83542b5f0e89d33a7882c7b773
Author: Christoph Keller <ke...@gmail.com>
Date: 2016-02-20T09:15:04Z
added some boxes and fixed omnios
commit 43cb10796677d99940aee6991cff568d982b82f0
Author: Christoph Keller <ke...@gmail.com>
Date: 2016-02-20T09:43:12Z
use prebuilt tcl instead of compiling
commit 1f1a3e993d83f57921b4dd1f5848a0cad64ffed5
Author: Christoph Keller <ke...@gmail.com>
Date: 2016-02-20T09:48:36Z
added license information
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-189485555
Thanks @christoph-k86!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
Posted by christoph-k86 <gi...@git.apache.org>.
Github user christoph-k86 commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-187040469
Yeah i know what you mean about that patch series... working on it
I just checked for configure to run in default configuration when looking for those dependencies trying to keep the images small.
I can add those optional dependencies as well. Would be great if they were documented as optional though ([doclink] (https://docs.trafficserver.apache.org/en/stable/getting-started/index.en.html#installation)).
What do you think about dependencies for plugins? Shall they be added as well?
That FreeBSD image is gone and there wasn't any provisioning at all so that probably never worked ootb anyways. If that's still needed i'll try to add it as well but i'd prefer to do that after all the other stuff is working again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/490
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-186950232
This looks generally reasonable.
I'd like the patch series to be a bit cleaner; maybe fix the vagrant box URLs in the first commit, then switch over to the shell provisioner.
We need to retain the additional build packages (``libcap-devel``, etc) so that optional components are always detected and built. It looks like you dropped FreeBSD, was that deliberate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-187268952
> Yeah i know what you mean about that patch series... working on it
thanks :)
> I just checked for configure to run in default configuration when looking for those dependencies
> trying to keep the images small.
>
> I can add those optional dependencies as well. Would be great if they were documented as optional
> though (doclink).
>
> What do you think about dependencies for plugins? Shall they be added as well?
The original goal of these was so that dev could spin up build environments for configurations they didn't have easy access to, which meant that I installed all the dependencies to build all the optional components. If you can get all the dependencies in, that would be great. On RHEL-based systems I remember it was a bit tedious to get the right dependencies out of EPEL though.
> That FreeBSD image is gone and there wasn't any provisioning at all so that probably never worked
> ootb anyways. If that's still needed i'll try to add it as well but i'd prefer to do that after all the other stuff
> is working again.
No that's fine; I just wanted to check whether this was a deliberate decision. A FreeBSD image will just bitrot again unless there's someone to take care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
Posted by bryancall <gi...@git.apache.org>.
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-187827174
@jpeach will shepard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4048: Broken Vagrantfile in a lot o...
Posted by christoph-k86 <gi...@git.apache.org>.
Github user christoph-k86 commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-189140495
I just added those optional dependencies.
Cleaning up that patch series is pretty hard though. Looks more like a complete rewrite than a couple of fixes. I'm still thinking about how to split all those changes without leaving it in an even worse state. Those commits work alltogether... applying only some of them does'nt really make any sense. Maybe just squash em?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---