You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/09/01 00:24:32 UTC
Re: Review Request 37964: Allow for slashes in metric names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37964/#review97169
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On Aug. 31, 2015, 2:34 p.m., Joe Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37964/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2015, 2:34 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-1282
> https://issues.apache.org/jira/browse/AURORA-1282
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Allow for slashes in metric names
>
>
> Diffs
> -----
>
> commons/src/main/java/org/apache/aurora/common/stats/Stats.java f2bd05d4739f5d0f07fae33ac6e7b32d12ce574d
> commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 91bbc096748952cc7dbf0cbd83a2d95456e0ce0a
>
> Diff: https://reviews.apache.org/r/37964/diff/
>
>
> Testing
> -------
>
> ```
> [tw-mbp-jsmith aurora (stats-slashes)]$ ./gradlew build -Pq
> # snip
>
> BUILD SUCCESSFUL
> ```
>
>
> Thanks,
>
> Joe Smith
>
>