You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/06 14:52:16 UTC

[GitHub] [pulsar] MarvinCai commented on a diff in pull request #17275: [cleanup][broker][Modernizer] fix violations in pulsar-broker

MarvinCai commented on code in PR #17275:
URL: https://github.com/apache/pulsar/pull/17275#discussion_r963809645


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/intercept/InterceptFilterOutTest.java:
##########
@@ -71,7 +71,7 @@ public void testFilterOutForPreInterceptFilter() throws Exception {
         Mockito.doNothing().when(chain).doFilter(Mockito.any(), Mockito.any());
         HttpServletRequestWrapper mockInputStream = new MockRequestWrapper(request);
         Mockito.doReturn(mockInputStream.getInputStream()).when(request).getInputStream();
-        Mockito.doReturn(new StringBuffer("http://127.0.0.1:8080")).when(request).getRequestURL();
+        Mockito.doReturn(new StringBuilder("http://127.0.0.1:8080")).when(request).getRequestURL();

Review Comment:
   method signature is   `StringBuffer getRequestURL();`, so can't use StringBuilder here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org