You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Junjie Peng (JIRA)" <ji...@apache.org> on 2008/07/07 06:07:31 UTC
[jira] Created: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
------------------------------------------------------------------------------------
Key: DERBY-3760
URL: https://issues.apache.org/jira/browse/DERBY-3760
Project: Derby
Issue Type: Test
Components: Test
Environment: windows xp, sp2.
Reporter: Junjie Peng
Assignee: Junjie Peng
Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612734#action_12612734 ]
Junjie Peng commented on DERBY-3760:
------------------------------------
I've got it. Thank you for detailed instructions.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613271#action_12613271 ]
Junjie Peng commented on DERBY-3760:
------------------------------------
Thanks, Kristian.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Fix For: 10.5.0.0
>
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt, derby-3760-3-patch.txt, derby-3760-3-stat.txt, derby-3760-3a.diff
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612428#action_12612428 ]
Kristian Waagan commented on DERBY-3760:
----------------------------------------
3) I meant it is just a spelling error. "strongger" -> "stronger"
4) No, and yes... With trailing whitespace I mean lines like those below, using "_" as a marker for space/tabs.
____public_void_s(a,_b)_{
________return_(a+b);_______ <== Trailing whitespace.
____}
____ <== Trailing whitespace
____public_void_d(a,_b)_{
The extra whitespace doesn't hurt the code, they just light up in my editor :)
We do have some guidelines for code, but as long as you use 4 spaces for indentation in new code (no tabs), keep lines below 80 characters and write clear code you're safe :)
When editing existing code people tend to do different things regarding spaces and tabs.
I tend to always use spaces, unless I edit/add a single line and all surrounding code uses tabs.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3760:
-------------------------------
Attachment: derby-3760-1-stat.txt
derby-3760-1-patch.txt
Please check the patch!
And I have a question, what do Line 46 "set isolation serializable;" mean in miscerros.sql? Could it be removed? Thank you!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3760:
-----------------------------------
Attachment: derby-3760-3a.diff
'derby-3760-3a.diff' incorporates the following tiny changes:
- removed some trailing whitespace
- renamed method with typo
- changed class comment
- replaced ';' with '.' in a comment
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt, derby-3760-3-patch.txt, derby-3760-3-stat.txt, derby-3760-3a.diff
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612417#action_12612417 ]
Junjie Peng commented on DERBY-3760:
------------------------------------
Thank you, Kristian.
I'm still not clear about:
3) Typo: "strongger" ----------how to typo it in code file?
5) Some trailing whitespace in MiscErrorsTest --------do we have some common code templates file to format code?
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng closed DERBY-3760.
------------------------------
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Fix For: 10.5.0.0
>
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt, derby-3760-3-patch.txt, derby-3760-3-stat.txt, derby-3760-3a.diff
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan updated DERBY-3760:
-----------------------------------
Description: Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC. (was: Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.)
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3760:
-------------------------------
Attachment: derby-3760-2-stat.txt
derby-3760-2-patch.txt
Delete miscerror.sql from java\testing\org\apache\derbyTesting\functionTests\tests\lang\LangScripts.java.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612409#action_12612409 ]
Kristian Waagan commented on DERBY-3760:
----------------------------------------
My comments on the patch:
1) Unnecessary diff in LangScripts (line "logop" now contains trailing whitespace)
2) "set isolation serializable" does exactly that, it sets the transaction isolation level to serializable.
See for instance http://en.wikipedia.org/wiki/Isolation_(computer_science) for an introduction.
I do not see why it's in the test and suggest you remove it. Anyone else understand why it's in there?
[MiscErrorsTest]
3) Typo: "strongger"
4) The test fails for me, because the result set ordering is different. Two ways to fix that: order the results, or use 'JDBC.assertUnorderedResultSet'.
Tiny nits and personal preferences (often I don't comment on these things):
5) Some trailing whitespace in MiscErrorsTest
6) No need to add a @throws tag if nothing is written there
thanks,
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.precedence.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Junjie Peng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Junjie Peng updated DERBY-3760:
-------------------------------
Attachment: derby-3760-3-stat.txt
derby-3760-3-patch.txt
Please check the new patch. Thanks!
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt, derby-3760-3-patch.txt, derby-3760-3-stat.txt
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-3760) Convert
"org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-3760.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.5.0.0
Derby Info: (was: [Patch Available])
Committed patch 3a to trunk with revision 676515.
Thanks for the work, Junjie.
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit.
> ------------------------------------------------------------------------------------
>
> Key: DERBY-3760
> URL: https://issues.apache.org/jira/browse/DERBY-3760
> Project: Derby
> Issue Type: Test
> Components: Test
> Environment: windows xp, sp2.
> Reporter: Junjie Peng
> Assignee: Junjie Peng
> Fix For: 10.5.0.0
>
> Attachments: derby-3760-1-patch.txt, derby-3760-1-stat.txt, derby-3760-2-patch.txt, derby-3760-2-stat.txt, derby-3760-3-patch.txt, derby-3760-3-stat.txt, derby-3760-3a.diff
>
> Original Estimate: 120h
> Remaining Estimate: 120h
>
> Convert "org.apache.derbyTesting.functionTests.tests.lang.miscerrors.sql" to junit. It it a part of 2008 GSOC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.