You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/04/20 19:38:33 UTC

[GitHub] [accumulo] jmark99 commented on a change in pull request #1590: Use isEmpty() rather than size()/length() checks.

jmark99 commented on a change in pull request #1590:
URL: https://github.com/apache/accumulo/pull/1590#discussion_r411639834



##########
File path: test/src/main/java/org/apache/accumulo/test/functional/KerberosIT.java
##########
@@ -565,8 +565,8 @@ public void testRestartedMasterReusesSecretKey() throws Exception {
               client.securityOperations().getDelegationToken(new DelegationTokenConfig());
 
           assertTrue("Could not get tables with delegation token",
-              mac.createAccumuloClient(rootUser.getPrincipal(), token).tableOperations().list()
-                  .size() > 0);
+              !mac.createAccumuloClient(rootUser.getPrincipal(), token).tableOperations().list()
+                  .isEmpty());

Review comment:
       True! Will keep in mind for future update.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org