You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/10 14:08:57 UTC

[GitHub] [superset] villebro commented on pull request #16090: feat(explore): each control can define its own canDrop for dnd

villebro commented on pull request #16090:
URL: https://github.com/apache/superset/pull/16090#issuecomment-896060614


   I agree with Kamil's assessment and see this as improving decoupling. By adding this we can let both components decide about the things they have the best context on. Without it we face a situation where we would need to make control1 aware of logic that should be inside control2 and vice versa.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org