You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/05/14 07:40:03 UTC

[GitHub] [incubator-mxnet] bgawrych opened a new pull request #18317: [1.x] Backport of fix LSTM and GRU layers gradient calculations

bgawrych opened a new pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317


   ## Description ##
   Fix for LSTM and GRU layers without DNNL enabled give wrong gradients #17898
   
   For bidiractional LSTM with number of layers > 2 input gradient calculation was incorrect.
   Reason of wrong calculations was overwriting y derivative (dy) tensor by
   calculated x derivative (dx) tensor before right2left layer could use dy for own
   gradient calculations.
   
   For GRU with number of layers > 2 i2h_weight gradient for
   layers in the middle (all except last and first) was incorrect.
   Wrong caluculations were caused by assigning output pointer to
   input instead of calculating new input pointer.
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ## Comments ##
   This PR is backport of #18203


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-636724337


   Jenkins CI successfully triggered : [centos-gpu, clang, miscellaneous, sanity, unix-cpu, unix-gpu, windows-cpu, centos-cpu, edge, website, windows-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-636757532


   > Hi @bgawrych , I found recently there's a PR #18437 which delete the `ln -s /usr/bin/ninja-build /usr/bin/ninja` from the ci script file.
   > So the new code base will not run into such failure, please try rebase your code. Thanks.
   > I've create another PR for fixing the issue for v1.7.x branch.
   
   @ciyongch Done, but there is only 1 check now. Tried to retrigger all jobs, but no effect


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-634552427


   Jenkins CI successfully triggered : [edge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-635494330


   Jenkins CI successfully triggered : [centos-cpu, centos-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of fix LSTM and GRU layers gradient calculations

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-628452048


   Hey @bgawrych , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, miscellaneous, centos-gpu, unix-gpu, website, sanity, unix-cpu, centos-cpu, clang, edge, windows-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-636632909


   Jenkins CI successfully triggered : [centos-cpu, centos-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] ciyongch commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-636759242


   @bgawrych , it's good, all the tests got passed now :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-631330666


   Jenkins CI successfully triggered : [unix-gpu, edge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-635494245


   @mxnet-bot run ci [centos-cpu, centos-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-635136767


   @mxnet-bot run ci [centos-cpu, centos-gpu, unix-cpu, unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-633426196


   Jenkins CI successfully triggered : [edge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-636724209


   @mxnet-bot run ci [all]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych removed a comment on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych removed a comment on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-631262376


   @mxnet-bot run ci [edge, unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-633426144


   @mxnet-bot run ci [edge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-637307088


   Jenkins CI successfully triggered : [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-633885238


   Jenkins CI successfully triggered : [edge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-631262376


   @mxnet-bot run ci [edge, unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] ciyongch commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
ciyongch commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-636655487


   Hi @bgawrych , I found recently there's a PR https://github.com/apache/incubator-mxnet/pull/18437 which delete the `ln -s /usr/bin/ninja-build /usr/bin/ninja` from the ci script file. 
   So the new code base will not run into such failure, please try rebase your code. Thanks.
   I've create another PR for fixing the issue for v1.7.x branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-635136835


   Jenkins CI successfully triggered : [centos-cpu, centos-gpu, unix-gpu, unix-cpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-636632875


   @mxnet-bot run ci [centos-cpu, centos-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-637984872


   I thinnk it's ready too
   cc @ciyongch @pengzhao-intel @TaoLv 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-637307037


   @mxnet-bot run ci [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-633885174


   @mxnet-bot run ci [edge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] pengzhao-intel merged pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
pengzhao-intel merged pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-634552336


   @mxnet-bot run ci [edge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] bgawrych commented on pull request #18317: [1.x] Backport of LSTM and GRU fix (#17898) and RNN op (#17632)

Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #18317:
URL: https://github.com/apache/incubator-mxnet/pull/18317#issuecomment-631330615


   @mxnet-bot run ci [edge, unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org