You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/06 16:09:51 UTC
[GitHub] john-bodley commented on a change in pull request #4543: Setting up compression using flask-compress
john-bodley commented on a change in pull request #4543: Setting up compression using flask-compress
URL: https://github.com/apache/incubator-superset/pull/4543#discussion_r172569182
##########
File path: superset/utils.py
##########
@@ -838,3 +843,38 @@ def get_filter_key(f):
def get_update_perms_flag():
val = os.environ.get('SUPERSET_UPDATE_PERMS')
return val.lower() not in ('0', 'false', 'no') if val else True
+
+
+def gzipped(f):
Review comment:
Max is this required? I felt that `Flask-Compress` takes care of all of this. Also would it be possible to report the time it takes to execute the `sql_json` and `explore_json` endpoints w/ and w/o caching?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services