You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2023/10/10 00:33:25 UTC

[kudu-CR] [CMakeLists] clean-up ARCH NAME conditions for x86 64

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20552


Change subject: [CMakeLists] clean-up ARCH_NAME conditions for x86_64
......................................................................

[CMakeLists] clean-up ARCH_NAME conditions for x86_64

This patch simplifies the criteria based on ARCH_NAME in CMakeLists.

Change-Id: Iced035819fc54035d4cb654f4c206c3bd85aa660
---
M CMakeLists.txt
M src/kudu/gutil/CMakeLists.txt
2 files changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/20552/1
-- 
To view, visit http://gerrit.cloudera.org:8080/20552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iced035819fc54035d4cb654f4c206c3bd85aa660
Gerrit-Change-Number: 20552
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [CMakeLists] clean-up ARCH NAME conditions for x86 64

Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20552 )

Change subject: [CMakeLists] clean-up ARCH_NAME conditions for x86_64
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/20552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iced035819fc54035d4cb654f4c206c3bd85aa660
Gerrit-Change-Number: 20552
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Wed, 11 Oct 2023 02:52:08 +0000
Gerrit-HasComments: No

[kudu-CR] [CMakeLists] clean-up ARCH NAME conditions for x86 64

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/20552

to look at the new patch set (#2).

Change subject: [CMakeLists] clean-up ARCH_NAME conditions for x86_64
......................................................................

[CMakeLists] clean-up ARCH_NAME conditions for x86_64

This patch simplifies the criteria based on ARCH_NAME in CMakeLists.

Change-Id: Iced035819fc54035d4cb654f4c206c3bd85aa660
---
M CMakeLists.txt
M src/kudu/gutil/CMakeLists.txt
2 files changed, 8 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/20552/2
-- 
To view, visit http://gerrit.cloudera.org:8080/20552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iced035819fc54035d4cb654f4c206c3bd85aa660
Gerrit-Change-Number: 20552
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [CMakeLists] clean-up ARCH NAME conditions for x86 64

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20552 )

Change subject: [CMakeLists] clean-up ARCH_NAME conditions for x86_64
......................................................................

[CMakeLists] clean-up ARCH_NAME conditions for x86_64

This patch simplifies the criteria based on ARCH_NAME in CMakeLists.

Change-Id: Iced035819fc54035d4cb654f4c206c3bd85aa660
Reviewed-on: http://gerrit.cloudera.org:8080/20552
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <la...@apache.org>
---
M CMakeLists.txt
M src/kudu/gutil/CMakeLists.txt
2 files changed, 8 insertions(+), 7 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Yingchun Lai: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/20552
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iced035819fc54035d4cb654f4c206c3bd85aa660
Gerrit-Change-Number: 20552
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>