You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2016/07/13 07:41:12 UTC

[GitHub] flink pull request #2234: [hotfix][kinesis-connector] Remove duplicate info ...

GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/2234

    [hotfix][kinesis-connector] Remove duplicate info in KinesisDeserializationSchema

    The duplicate was added in https://github.com/apache/flink/pull/2225.
    `byte[] recordKey` and `String partitionKey` are actually the same only in different form, so now we have duplicate info in the deser schema. I think we can keep the `String` one, since it's the type we get from AWS API for the key.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink hf-kinesis-deser

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2234.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2234
    
----
commit f23a699f990ee5f86a12b2b5249a055c27ff1caf
Author: Gordon Tai <tz...@gmail.com>
Date:   2016-07-13T07:36:56Z

    [hotfix][kinesis-connector] Remove duplicate info in KinesisDeserializationSchema

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2234: [hotfix][kinesis-connector] Remove duplicate info in Kine...

Posted by rmetzger <gi...@git.apache.org>.

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2234
  
    Merging ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2234: [hotfix][kinesis-connector] Remove duplicate info ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2234


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---