You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/24 13:39:09 UTC

[GitHub] [airflow] potiuk opened a new pull request #10509: Add a possibility to switch back to building images by secret

potiuk opened a new pull request #10509:
URL: https://github.com/apache/airflow/pull/10509


   You can now define secret in your own fork:
   
   AIRFLOW_GITHUB_REGISTRY_WAIT_FOR_IMAGE
   
   If you set it to "false", it skips building images in separate
   workflow_run - images will be built in the jobs run in the
   CI Build run and they won't be pushed to the registry.
   
   Note - you can't have secrets starting with GITHUB_, that's why
   the AIRFLOW_* prefix
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #10509: Add a possibility to switch back to building images by secret

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10509:
URL: https://github.com/apache/airflow/pull/10509#issuecomment-679418168


   Seems to work @mik-laj !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #10509: Add a possibility to switch back to building images by secret

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10509:
URL: https://github.com/apache/airflow/pull/10509


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] mik-laj commented on pull request #10509: Add a possibility to switch back to building images by secret

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #10509:
URL: https://github.com/apache/airflow/pull/10509#issuecomment-679397753


   I have PR o my fork: https://github.com/mik-laj/airflow/pull/32


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org