[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command

[GitBox <gi...@apache.org>]

jhsenjaliya commented on a change in pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command
URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r287553190
 
 

 ##########
 File path: bin/gobblin-admin.sh
 ##########
 @@ -1,142 +0,0 @@
-#!/bin/bash
 
 Review comment:
   I was targeting to cleanup and simplify those too many scripts Gobblin has, which could be not only confusing for new users but also not a standard way of using it since all scripts have different params. user should really move to new scripts to standardize, so not sure how much the backward compatibility is required for scripts, as oppose to APIs, otherwise we will never be able to clean up and provide better version. but I see ur point so may be I will create wrapper as you suggested with note to remove those wrapper in future but i afraid it wont be 100% backward compatible since loy of things (options and features) are getting standardized here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services