You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Yaron (JIRA)" <ji...@apache.org> on 2011/05/05 12:21:03 UTC

[jira] [Created] (WICKET-3668) Session.getPageMaps is not thread safe.

Session.getPageMaps is not thread safe.
---------------------------------------

                 Key: WICKET-3668
                 URL: https://issues.apache.org/jira/browse/WICKET-3668
             Project: Wicket
          Issue Type: Bug
          Components: wicket-core
    Affects Versions: 1.4.17
            Reporter: Yaron


Session.getPageMaps first gets all attributes names, then it add all pageMaps with a name of a pageMap.

But another thread with the same session might remove the attribute in the time between the get attribues names and the get of the attribute.
So the result will include a null object that will throw null pointer in the sort.

The senario is basicly related to previous bug where pageMap was created for link with popup (So pageMap would exceed max level and massive removal of pageMaps).
But this could still happen, and should be easy to fix (Just don't add a null pageMap to the list)...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-3668) Session.getPageMaps is not thread safe.

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.

     [ https://issues.apache.org/jira/browse/WICKET-3668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-3668.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4.18
         Assignee: Igor Vaynberg

> Session.getPageMaps is not thread safe.
> ---------------------------------------
>
>                 Key: WICKET-3668
>                 URL: https://issues.apache.org/jira/browse/WICKET-3668
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-core
>    Affects Versions: 1.4.17
>            Reporter: Yaron
>            Assignee: Igor Vaynberg
>              Labels: wicket
>             Fix For: 1.4.18
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Session.getPageMaps first gets all attributes names, then it add all pageMaps with a name of a pageMap.
> But another thread with the same session might remove the attribute in the time between the get attribues names and the get of the attribute.
> So the result will include a null object that will throw null pointer in the sort.
> The senario is basicly related to previous bug where pageMap was created for link with popup (So pageMap would exceed max level and massive removal of pageMaps).
> But this could still happen, and should be easy to fix (Just don't add a null pageMap to the list)...

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira