You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2009/08/29 13:29:15 UTC
[jira] Created: (CAMEL-1960) Enricher - AggregationStrategy -
Problem with preparing logic
Enricher - AggregationStrategy - Problem with preparing logic
-------------------------------------------------------------
Key: CAMEL-1960
URL: https://issues.apache.org/activemq/browse/CAMEL-1960
Project: Apache Camel
Issue Type: Bug
Components: camel-core
Affects Versions: 2.1.0
Reporter: Claus Ibsen
Assignee: Claus Ibsen
Fix For: 2.1.0
The ExchangeHelper.prepareAggregation method moves the message to IN to avoid confusing end users whether what they are looking for is on either IN or OUT.
Hover we some recent changes in MessageSupport to clear some headers it could cause problems as it was in fact the same message being copied from OUT to IN.
What it should do instead is to *move* it instead of using copy mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1960) Enricher - AggregationStrategy -
Problem with preparing logic
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53884#action_53884 ]
Willem Jiang commented on CAMEL-1960:
-------------------------------------
@Claus,
Yeah, I just merged the check code back to camel-1.x branch.
Will commit the patch after running the test.
> Enricher - AggregationStrategy - Problem with preparing logic
> -------------------------------------------------------------
>
> Key: CAMEL-1960
> URL: https://issues.apache.org/activemq/browse/CAMEL-1960
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.1.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.1.0
>
>
> The ExchangeHelper.prepareAggregation method moves the message to IN to avoid confusing end users whether what they are looking for is on either IN or OUT.
> Hover we some recent changes in MessageSupport to clear some headers it could cause problems as it was in fact the same message being copied from OUT to IN.
> What it should do instead is to *move* it instead of using copy mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1960) Enricher - AggregationStrategy -
Problem with preparing logic
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53878#action_53878 ]
Claus Ibsen commented on CAMEL-1960:
------------------------------------
@Willem excactly
This is what I am adding
if (that == this) {
// the same instance so do not need to copy
return;
}
> Enricher - AggregationStrategy - Problem with preparing logic
> -------------------------------------------------------------
>
> Key: CAMEL-1960
> URL: https://issues.apache.org/activemq/browse/CAMEL-1960
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.1.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.1.0
>
>
> The ExchangeHelper.prepareAggregation method moves the message to IN to avoid confusing end users whether what they are looking for is on either IN or OUT.
> Hover we some recent changes in MessageSupport to clear some headers it could cause problems as it was in fact the same message being copied from OUT to IN.
> What it should do instead is to *move* it instead of using copy mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-1960) Enricher - AggregationStrategy -
Problem with preparing logic
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-1960.
--------------------------------
Resolution: Fixed
trunk: 809122.
> Enricher - AggregationStrategy - Problem with preparing logic
> -------------------------------------------------------------
>
> Key: CAMEL-1960
> URL: https://issues.apache.org/activemq/browse/CAMEL-1960
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.1.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.1.0
>
>
> The ExchangeHelper.prepareAggregation method moves the message to IN to avoid confusing end users whether what they are looking for is on either IN or OUT.
> Hover we some recent changes in MessageSupport to clear some headers it could cause problems as it was in fact the same message being copied from OUT to IN.
> What it should do instead is to *move* it instead of using copy mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1960) Enricher - AggregationStrategy -
Problem with preparing logic
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53877#action_53877 ]
Claus Ibsen commented on CAMEL-1960:
------------------------------------
It was CAMEL-1955
> Enricher - AggregationStrategy - Problem with preparing logic
> -------------------------------------------------------------
>
> Key: CAMEL-1960
> URL: https://issues.apache.org/activemq/browse/CAMEL-1960
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.1.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.1.0
>
>
> The ExchangeHelper.prepareAggregation method moves the message to IN to avoid confusing end users whether what they are looking for is on either IN or OUT.
> Hover we some recent changes in MessageSupport to clear some headers it could cause problems as it was in fact the same message being copied from OUT to IN.
> What it should do instead is to *move* it instead of using copy mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1960) Enricher - AggregationStrategy -
Problem with preparing logic
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53876#action_53876 ]
Willem Jiang commented on CAMEL-1960:
-------------------------------------
Maybe we just need to add a check in the MessageSupport.copyFrom(), to skip to copy work of the same message.
> Enricher - AggregationStrategy - Problem with preparing logic
> -------------------------------------------------------------
>
> Key: CAMEL-1960
> URL: https://issues.apache.org/activemq/browse/CAMEL-1960
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.1.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.1.0
>
>
> The ExchangeHelper.prepareAggregation method moves the message to IN to avoid confusing end users whether what they are looking for is on either IN or OUT.
> Hover we some recent changes in MessageSupport to clear some headers it could cause problems as it was in fact the same message being copied from OUT to IN.
> What it should do instead is to *move* it instead of using copy mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-1960) Enricher - AggregationStrategy -
Problem with preparing logic
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=53879#action_53879 ]
Claus Ibsen commented on CAMEL-1960:
------------------------------------
Willem can you merge the fix in MessageSupport to Camel 1.6.2 as it should apply in that release as well?
> Enricher - AggregationStrategy - Problem with preparing logic
> -------------------------------------------------------------
>
> Key: CAMEL-1960
> URL: https://issues.apache.org/activemq/browse/CAMEL-1960
> Project: Apache Camel
> Issue Type: Bug
> Components: camel-core
> Affects Versions: 2.1.0
> Reporter: Claus Ibsen
> Assignee: Claus Ibsen
> Fix For: 2.1.0
>
>
> The ExchangeHelper.prepareAggregation method moves the message to IN to avoid confusing end users whether what they are looking for is on either IN or OUT.
> Hover we some recent changes in MessageSupport to clear some headers it could cause problems as it was in fact the same message being copied from OUT to IN.
> What it should do instead is to *move* it instead of using copy mechanism.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.