You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/20 21:09:01 UTC

[GitHub] [incubator-superset] DiggidyDave commented on a change in pull request #8076: event logging changes

DiggidyDave commented on a change in pull request #8076: event logging changes
URL: https://github.com/apache/incubator-superset/pull/8076#discussion_r315904260
 
 

 ##########
 File path: superset/utils/event_logger.py
 ##########
 @@ -22,17 +22,77 @@
 import json
 import logging
 import textwrap
-from typing import Any, cast, Type
+import time
+from typing import Any, cast, List, Type
 
-from flask import current_app, g, request
+from flask import current_app, g, request, Response
+
+SUPERSET_EVENT_LOGGER_NAME = "superset_events"
+
+
+class SupersetEvent(object):
 
 Review comment:
   heh I'm not even sure why I did that, I think some dormant pathway in my brain woke up.  I've got a lot of fixes coming, I'll remove that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org