You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2023/10/21 14:39:17 UTC
[PR] [METRICS] Return metrics snapshot with line delimiter [incubator-celeborn]
turboFei opened a new pull request, #2011:
URL: https://github.com/apache/incubator-celeborn/pull/2011
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Now for the metrics snapshot, all of them flatten in one line.
<img width="1722" alt="image" src="https://github.com/apache/incubator-celeborn/assets/6757692/97085a08-6499-4a86-b787-6ac758ad6606">
In this pr, the metrics snapshot will be separated by new line.
### Why are the changes needed?
User friendly for metrics review with API
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Test locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [METRICS] Return metrics snapshot separated by new line [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #2011: [METRICS] Return metrics snapshot separated by new line
URL: https://github.com/apache/incubator-celeborn/pull/2011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [METRICS] Return metrics snapshot separated by new line [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #2011: [METRICS] Return metrics snapshot separated by new line
URL: https://github.com/apache/incubator-celeborn/pull/2011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [METRICS] Return metrics snapshot separated by new line [incubator-celeborn]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2011:
URL: https://github.com/apache/incubator-celeborn/pull/2011#issuecomment-1773830315
not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [METRICS] Return metrics snapshot separated by new line [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2011:
URL: https://github.com/apache/incubator-celeborn/pull/2011#issuecomment-1773817426
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2011?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2011](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2011?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (17332c4) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/f93be45506d3ec4a0aa2b4cfb9327a05926071cd?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f93be45) will **increase** coverage by `0.11%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #2011 +/- ##
==========================================
+ Coverage 46.64% 46.74% +0.11%
==========================================
Files 165 165
Lines 10531 10531
Branches 959 959
==========================================
+ Hits 4911 4922 +11
+ Misses 5295 5284 -11
Partials 325 325
```
| [Files](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2011?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...leborn/common/metrics/sink/PrometheusServlet.scala](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2011?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvY2VsZWJvcm4vY29tbW9uL21ldHJpY3Mvc2luay9Qcm9tZXRoZXVzU2VydmxldC5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2011/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org