You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/04/21 03:08:54 UTC
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15765
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
IMPALA-9574: support ubuntu 18.04 base image
Automatically detect if we're on Ubuntu 16.04
or 18.04 and use the appropriate base image.
Testing:
Built an image locally on my Ubuntu 18.04 system and
made sure I could start a minicluster and run a query.
Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
---
M docker/CMakeLists.txt
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/15765/1
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
LGTM
http://gerrit.cloudera.org:8080/#/c/15765/2/docker/impala_base/Dockerfile
File docker/impala_base/Dockerfile:
http://gerrit.cloudera.org:8080/#/c/15765/2/docker/impala_base/Dockerfile@17
PS2, Line 17: ARG BASE_IMAGE=ubuntu:16.04
Can this default value ever be used now that we expect BASE_IMAGE to be always set as in the docker invocation?
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 23:51:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/5842/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 05:55:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Anurag Mantripragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15765
to look at the new patch set (#2).
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
IMPALA-9574: support ubuntu 18.04 base image
Automatically detect if we're on Ubuntu 16.04
or 18.04 and use the appropriate base image.
Testing:
Built an image locally on my Ubuntu 18.04 system and
made sure I could start a minicluster and run a query.
Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
---
M docker/CMakeLists.txt
M docker/impala_base/Dockerfile
2 files changed, 92 insertions(+), 70 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/15765/2
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 2: Code-Review+1
Looks good to me.
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 06:11:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5688/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 00:27:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Anurag Mantripragada (Code Review)" <ge...@cloudera.org>.
Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 1:
Is this a part of a bigger change? I do not see L22 - L48 in asf master branch.
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 03:39:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 04:46:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 00:27:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 1:
You're right, I didn't squash this.
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 05:15:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
IMPALA-9574: support ubuntu 18.04 base image
Automatically detect if we're on Ubuntu 16.04
or 18.04 and use the appropriate base image.
Testing:
Built an image locally on my Ubuntu 18.04 system and
made sure I could start a minicluster and run a query.
Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Reviewed-on: http://gerrit.cloudera.org:8080/15765
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docker/CMakeLists.txt
M docker/impala_base/Dockerfile
2 files changed, 92 insertions(+), 70 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9574: support ubuntu 18.04 base image
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15765 )
Change subject: IMPALA-9574: support ubuntu 18.04 base image
......................................................................
Patch Set 1: -Verified
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/5839/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/15765
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8dfdb349e78fd76b91138a70449d51b0ef0021df
Gerrit-Change-Number: 15765
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <an...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 03:50:25 +0000
Gerrit-HasComments: No