You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/09/03 23:55:16 UTC

[GitHub] [incubator-druid] himanshug commented on a change in pull request #7537: Avoid file rename when pushing segments with HDFSDataPusher

himanshug commented on a change in pull request #7537:  Avoid file rename when pushing segments with HDFSDataPusher
URL: https://github.com/apache/incubator-druid/pull/7537#discussion_r320523978
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/segment/realtime/plumber/RealtimePlumber.java
 ##########
 @@ -454,7 +454,7 @@ public void doRun()
               DataSegment segment = dataSegmentPusher.push(
                   mergedFile,
                   sink.getSegment().withDimensions(IndexMerger.getMergedDimensionsFromQueryableIndexes(indexes)),
-                  false
+                  true
 
 Review comment:
   writing to tmp and then doing `rename` provided atomic write ... now if there are 3 replicas , trying to push concurrently ... who wins and is it guaranteed that end result will not be corrupted ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org