You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by "homatthew (via GitHub)" <gi...@apache.org> on 2023/02/28 05:10:43 UTC

[GitHub] [gobblin] homatthew opened a new pull request, #3651: Upgrade Mockito

homatthew opened a new pull request, #3651:
URL: https://github.com/apache/gobblin/pull/3651

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX

### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):

### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:

### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] homatthew commented on a diff in pull request #3651: [GOBBLIN-1792] Upgrade Mockito to 4.*

Posted by "homatthew (via GitHub)" <gi...@apache.org>.

homatthew commented on code in PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#discussion_r1163182255


##########
gobblin-yarn/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker:
##########
@@ -0,0 +1 @@
+mock-maker-inline

Review Comment:
   @meethngala 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] codecov-commenter commented on pull request #3651: Upgrade Mockito

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.

codecov-commenter commented on PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#issuecomment-1447632307

   # [Codecov](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3651](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (123d9c4) into [master](https://codecov.io/gh/apache/gobblin/commit/0a49cdb7db62171a1abcfdbb1934a24477807812?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0a49cdb) will **increase** coverage by `7.39%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3651      +/-   ##
   ============================================
   + Coverage     46.60%   54.00%   +7.39%     
   + Complexity    10715     1370    -9345     
   ============================================
     Files          2133      278    -1855     
     Lines         83651     9870   -73781     
     Branches       9301     1066    -8235     
   ============================================
   - Hits          38984     5330   -33654     
   + Misses        41110     4039   -37071     
   + Partials       3557      501    -3056     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh) | `48.09% <0.00%> (-1.33%)` | :arrow_down: |
   | [...odules/orchestration/InMemoryUserQuotaManager.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0luTWVtb3J5VXNlclF1b3RhTWFuYWdlci5qYXZh) | `70.07% <0.00%> (-0.79%)` | :arrow_down: |
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../apache/gobblin/util/test/RetentionTestHelper.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vdXRpbC90ZXN0L1JldGVudGlvblRlc3RIZWxwZXIuamF2YQ==) | | |
   | [...time/spec\_executorInstance/MockedSpecExecutor.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19leGVjdXRvckluc3RhbmNlL01vY2tlZFNwZWNFeGVjdXRvci5qYXZh) | | |
   | [.../apache/gobblin/util/ApplicationLauncherUtils.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvQXBwbGljYXRpb25MYXVuY2hlclV0aWxzLmphdmE=) | | |
   | [...ermark/FullPathCopyableFileWatermarkGenerator.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvd2F0ZXJtYXJrL0Z1bGxQYXRoQ29weWFibGVGaWxlV2F0ZXJtYXJrR2VuZXJhdG9yLmphdmE=) | | |
   | [...itychecker/task/TaskLevelPolicyCheckerBuilder.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3F1YWxpdHljaGVja2VyL3Rhc2svVGFza0xldmVsUG9saWN5Q2hlY2tlckJ1aWxkZXIuamF2YQ==) | | |
   | [...ement/conversion/hive/task/HiveConverterUtils.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS90YXNrL0hpdmVDb252ZXJ0ZXJVdGlscy5qYXZh) | | |
   | [...che/gobblin/compaction/mapreduce/orc/OrcUtils.java](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL29yYy9PcmNVdGlscy5qYXZh) | | |
   | ... and [1851 more](https://codecov.io/gh/apache/gobblin/pull/3651?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] homatthew commented on a diff in pull request #3651: [GOBBLIN-1792] Upgrade Mockito to 4.*

Posted by "homatthew (via GitHub)" <gi...@apache.org>.

homatthew commented on code in PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#discussion_r1122433937


##########
gradle/scripts/globalDependencies.gradle:
##########
@@ -57,6 +57,7 @@ subprojects {
         }
       }
       all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
+      all*.exclude group: 'org.mockito', module: 'mockito-all'

Review Comment:
   Actually. I don't think we need this. There is no transitive on mockito-all dependency in the latest iteration (maybe there was when I was drafting the PR). I am going to remove this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] homatthew commented on a diff in pull request #3651: [GOBBLIN-1792] Upgrade Mockito to 4.*

Posted by "homatthew (via GitHub)" <gi...@apache.org>.

homatthew commented on code in PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#discussion_r1163182255


##########
gobblin-yarn/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker:
##########
@@ -0,0 +1 @@
+mock-maker-inline

Review Comment:
   @meethngala 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] Will-Lo merged pull request #3651: [GOBBLIN-1792] Upgrade Mockito to 4.*

Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.

Will-Lo merged PR #3651:
URL: https://github.com/apache/gobblin/pull/3651


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3651: [GOBBLIN-1792] Upgrade Mockito to 4.*

Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.

Will-Lo commented on code in PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#discussion_r1122276405


##########
gradle/scripts/globalDependencies.gradle:
##########
@@ -57,6 +57,7 @@ subprojects {
         }
       }
       all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
+      all*.exclude group: 'org.mockito', module: 'mockito-all'

Review Comment:
   Can we leave a comment why we need to make this exclusion?



##########
gobblin-aws/src/test/java/org/apache/gobblin/aws/GobblinAWSClusterLauncherTest.java:
##########
@@ -64,6 +44,19 @@
 import org.apache.gobblin.cluster.TestHelper;
 import org.apache.gobblin.cluster.TestShutdownMessageHandlerFactory;
 import org.apache.gobblin.testing.AssertWithBackoff;
+import org.apache.helix.HelixManager;
+import org.apache.helix.HelixManagerFactory;
+import org.apache.helix.InstanceType;
+import org.apache.helix.model.Message;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.MockitoAnnotations;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;

Review Comment:
   Can we follow the import order on the style guide?
   https://gobblin.apache.org/docs/developer-guide/CodingStyle/
   There's an intellij file you can set as the guide and intellij can autoformat the imports for you.
   On a side note I should look into trying to enforce this as part of checkstyle but that'll come later<sup>tm</sup>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] homatthew commented on a diff in pull request #3651: [GOBBLIN-1792] Upgrade Mockito to 4.*

Posted by "homatthew (via GitHub)" <gi...@apache.org>.

homatthew commented on code in PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#discussion_r1164827929


##########
gobblin-yarn/src/test/resources/mockito-extensions/org.mockito.plugins.MockMaker:
##########
@@ -0,0 +1 @@
+mock-maker-inline

Review Comment:
   Example of mock-maker-inline plugin for enabling mockito-inline



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org