You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "candiduslynx (via GitHub)" <gi...@apache.org> on 2023/04/25 10:58:15 UTC

[GitHub] [arrow] candiduslynx commented on a diff in pull request #35327: GH-35326: [Go] Fix `*array.List` and `*array.LargeList` `ValueOffsets` implementation

candiduslynx commented on code in PR #35327:
URL: https://github.com/apache/arrow/pull/35327#discussion_r1176350352


##########
go/arrow/cdata/cdata_exports.go:
##########
@@ -416,13 +416,6 @@ func exportArray(arr arrow.Array, out *CArrowArray, outSchema *CArrowSchema) {
 		exportArray(arr.ListValues(), &children[0], nil)
 		childPtrs[0] = &children[0]
 		out.children = (**CArrowArray)(unsafe.Pointer(&childPtrs[0]))
-	case *array.FixedSizeList:

Review Comment:
   removed per matching `array.ListLike` above (unreachable code issue)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org