You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2021/01/13 10:30:16 UTC
[GitHub] [shiro] Palak-137 opened a new pull request #279: Pr template
Palak-137 opened a new pull request #279:
URL: https://github.com/apache/shiro/pull/279
According to the issue on Jira the pull_request_template.md needs to be updated.
So I added the guideline to add -Purn-its to activate profile test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a change in pull request #279: [SHIRO-802] Pr template
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #279:
URL: https://github.com/apache/shiro/pull/279#discussion_r557088291
##########
File path: .github/pull_request_template.md
##########
@@ -9,6 +9,7 @@ Following this checklist to help us incorporate your contribution quickly and ea
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] By default the project packages the tests in an artifact. To activate them Run `mvn clean test -Purn-its`.
Review comment:
typo: `run-its`, not `urn-its`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a change in pull request #279: [SHIRO-802] Pr template
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #279:
URL: https://github.com/apache/shiro/pull/279#discussion_r557167880
##########
File path: .github/pull_request_template.md
##########
@@ -9,6 +9,7 @@ Following this checklist to help us incorporate your contribution quickly and ea
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] By default the project packages the tests in an artifact. To activate them,activate the `run-its` profile: `mvn clean test -Purn-its`.
Review comment:
1. Still "urn-its".
2. test will not run its. You will need "clean verify".
3. nit: Please add a space after a comma (between "them,activate").
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] fpapon commented on pull request #279: [SHIRO-802] Pr template
Posted by GitBox <gi...@apache.org>.
fpapon commented on pull request #279:
URL: https://github.com/apache/shiro/pull/279#issuecomment-782047938
@Palak-137 can you squash the commits please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] Palak-137 commented on pull request #279: Pr template
Posted by GitBox <gi...@apache.org>.
Palak-137 commented on pull request #279:
URL: https://github.com/apache/shiro/pull/279#issuecomment-759384383
Yes i have revert the rest of changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a change in pull request #279: [SHIRO-802] Pr template
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #279:
URL: https://github.com/apache/shiro/pull/279#discussion_r557169231
##########
File path: .github/pull_request_template.md
##########
@@ -9,6 +9,7 @@ Following this checklist to help us incorporate your contribution quickly and ea
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] By default the project packages the tests in an artifact. To activate them,activate the `run-its` profile: `mvn clean test -Purn-its`.
Review comment:
Proposed: "to activate them, run `mvn clean test -Prun-its`.
##########
File path: .github/pull_request_template.md
##########
@@ -9,6 +9,7 @@ Following this checklist to help us incorporate your contribution quickly and ea
is to use the JIRA issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] By default the project packages the tests in an artifact. To activate them,activate the `run-its` profile: `mvn clean test -Purn-its`.
Review comment:
Proposed: "[…] To activate them, run `mvn clean test -Prun-its`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] bmarwell commented on a change in pull request #279: Pr template
Posted by GitBox <gi...@apache.org>.
bmarwell commented on a change in pull request #279:
URL: https://github.com/apache/shiro/pull/279#discussion_r556515361
##########
File path: lang/src/main/java/org/apache/shiro/lang/io/ClassResolvingObjectInputStream.java
##########
@@ -27,7 +27,8 @@
import java.io.ObjectStreamClass;
/**
- * Enables correct ClassLoader lookup in various environments (e.g. JEE Servers, etc).
Review comment:
This file must not be part of the commit. Please rebase and create the PR from a branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] Palak-137 closed pull request #279: [SHIRO-802] Pr template
Posted by GitBox <gi...@apache.org>.
Palak-137 closed pull request #279:
URL: https://github.com/apache/shiro/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shiro] Palak-137 closed pull request #279: Pr template
Posted by GitBox <gi...@apache.org>.
Palak-137 closed pull request #279:
URL: https://github.com/apache/shiro/pull/279
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org