You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Bill Lucy (JIRA)" <de...@myfaces.apache.org> on 2016/06/09 16:15:21 UTC
[jira] [Commented] (MYFACES-4050) Validators not invoked for empty
selectManyCheckbox components
[ https://issues.apache.org/jira/browse/MYFACES-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322783#comment-15322783 ]
Bill Lucy commented on MYFACES-4050:
------------------------------------
The fix I'm proposing here is straightforward - we're overriding UIInput.validateValue() in UISelectMany; we need to check shouldValidateEmptyFields() in the overridden method.
> Validators not invoked for empty selectManyCheckbox components
> --------------------------------------------------------------
>
> Key: MYFACES-4050
> URL: https://issues.apache.org/jira/browse/MYFACES-4050
> Project: MyFaces Core
> Issue Type: Bug
> Affects Versions: 2.2.10
> Environment: Tomcat, WebSphere Liberty
> Reporter: Bill Lucy
> Attachments: MYFACES-4050.patch
>
>
> Custom validators are not invoked for selectManyCheckbox component, if the component has no selections made; this can be an issue if we want to handle the null/empty case in a validator. The following context params address this case:
> <context-param>
> <param-name>javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL</param-name>
> <param-value>true</param-value>
> </context-param>
>
> <context-param>
> <param-name>javax.faces.VALIDATE_EMPTY_FIELDS</param-name>
> <param-value>true</param-value>
> </context-param>
> But these params do not affect the behavior here. Based on my understanding of the spec, it seems that this behavior should be changed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Re: [jira] [Commented] (MYFACES-4050) Validators not invoked for
empty selectManyCheckbox components
Posted by Bill Lucy <wt...@gmail.com>.
I've tested the fix here locally, with good results. If there are no
objections to my changing the behavior here then I'll commit the changes.
On Thu, Jun 9, 2016 at 12:15 PM, Bill Lucy (JIRA) <de...@myfaces.apache.org>
wrote:
>
> [
> https://issues.apache.org/jira/browse/MYFACES-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322783#comment-15322783
> ]
>
> Bill Lucy commented on MYFACES-4050:
> ------------------------------------
>
> The fix I'm proposing here is straightforward - we're overriding
> UIInput.validateValue() in UISelectMany; we need to check
> shouldValidateEmptyFields() in the overridden method.
>
> > Validators not invoked for empty selectManyCheckbox components
> > --------------------------------------------------------------
> >
> > Key: MYFACES-4050
> > URL: https://issues.apache.org/jira/browse/MYFACES-4050
> > Project: MyFaces Core
> > Issue Type: Bug
> > Affects Versions: 2.2.10
> > Environment: Tomcat, WebSphere Liberty
> > Reporter: Bill Lucy
> > Attachments: MYFACES-4050.patch
> >
> >
> > Custom validators are not invoked for selectManyCheckbox component, if
> the component has no selections made; this can be an issue if we want to
> handle the null/empty case in a validator. The following context params
> address this case:
> > <context-param>
> >
> <param-name>javax.faces.INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL</param-name>
> > <param-value>true</param-value>
> > </context-param>
> >
> > <context-param>
> > <param-name>javax.faces.VALIDATE_EMPTY_FIELDS</param-name>
> > <param-value>true</param-value>
> > </context-param>
> > But these params do not affect the behavior here. Based on my
> understanding of the spec, it seems that this behavior should be changed.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
>