You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (Created) (JIRA)" <ji...@apache.org> on 2012/02/21 13:48:34 UTC

[jira] [Created] (SLING-2424) DefaultSlingScript.service: Don't set content type and character enconding when included

DefaultSlingScript.service: Don't set content type and character enconding when included
----------------------------------------------------------------------------------------

                 Key: SLING-2424
                 URL: https://issues.apache.org/jira/browse/SLING-2424
             Project: Sling
          Issue Type: Improvement
          Components: Scripting
    Affects Versions: Scripting Core 2.0.20
            Reporter: Felix Meschberger


The DefaultSlingScript.service method which is called to hand the request over to a script (such as a JSP or Groovy Script) currently always sets the response content type and character encoding (for text content types).

This is overkill and may in fact ruin setup of calling scripts (in contrast to the Servlet API, Sling allows setting response headers in included scripts and servlets because such inclusion is central to how Sling requests are handled).

Thus the DefaultSlingScript.service method should only set these headers if not included (it is ok to set the headers if forward-ed because the request must be assumed clean in this case).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (SLING-2424) DefaultSlingScript.service: Don't set content type and character enconding when included

Posted by "Felix Meschberger (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger resolved SLING-2424.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: Scripting Core 2.0.22
         Assignee: Felix Meschberger

Fixed in Rev. 1291754
                
> DefaultSlingScript.service: Don't set content type and character enconding when included
> ----------------------------------------------------------------------------------------
>
>                 Key: SLING-2424
>                 URL: https://issues.apache.org/jira/browse/SLING-2424
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting Core 2.0.20
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Scripting Core 2.0.22
>
>
> The DefaultSlingScript.service method which is called to hand the request over to a script (such as a JSP or Groovy Script) currently always sets the response content type and character encoding (for text content types).
> This is overkill and may in fact ruin setup of calling scripts (in contrast to the Servlet API, Sling allows setting response headers in included scripts and servlets because such inclusion is central to how Sling requests are handled).
> Thus the DefaultSlingScript.service method should only set these headers if not included (it is ok to set the headers if forward-ed because the request must be assumed clean in this case).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (SLING-2424) DefaultSlingScript.service: Don't set content type and character enconding when included

Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-2424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carsten Ziegeler closed SLING-2424.
-----------------------------------

    
> DefaultSlingScript.service: Don't set content type and character enconding when included
> ----------------------------------------------------------------------------------------
>
>                 Key: SLING-2424
>                 URL: https://issues.apache.org/jira/browse/SLING-2424
>             Project: Sling
>          Issue Type: Improvement
>          Components: Scripting
>    Affects Versions: Scripting Core 2.0.20
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: Scripting Core 2.0.22
>
>
> The DefaultSlingScript.service method which is called to hand the request over to a script (such as a JSP or Groovy Script) currently always sets the response content type and character encoding (for text content types).
> This is overkill and may in fact ruin setup of calling scripts (in contrast to the Servlet API, Sling allows setting response headers in included scripts and servlets because such inclusion is central to how Sling requests are handled).
> Thus the DefaultSlingScript.service method should only set these headers if not included (it is ok to set the headers if forward-ed because the request must be assumed clean in this case).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira