[GitHub] [flink] twalthr commented on a change in pull request #10781: [FLINK-15281][table-planner-blink] Map Flink's TypeInference to Calcite's interfaces

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #10781: [FLINK-15281][table-planner-blink] Map Flink's TypeInference to Calcite's interfaces
URL: https://github.com/apache/flink/pull/10781#discussion_r364677631
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/functions/inference/TypeInferenceOperandChecker.java
 ##########
 @@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.functions.inference;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.api.ValidationException;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.planner.calcite.FlinkTypeFactory;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.CallContext;
+import org.apache.flink.table.types.inference.TypeInference;
+import org.apache.flink.table.types.inference.TypeInferenceUtil;
+import org.apache.flink.table.types.inference.utils.AdaptedCallContext;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import org.apache.calcite.rel.type.RelDataType;
+import org.apache.calcite.sql.SqlCallBinding;
+import org.apache.calcite.sql.SqlNode;
+import org.apache.calcite.sql.SqlOperandCountRange;
+import org.apache.calcite.sql.SqlOperator;
+import org.apache.calcite.sql.fun.SqlStdOperatorTable;
+import org.apache.calcite.sql.parser.SqlParserPos;
+import org.apache.calcite.sql.type.SqlOperandTypeChecker;
+import org.apache.calcite.sql.type.SqlTypeUtil;
+import org.apache.calcite.sql.validate.SqlValidator;
+import org.apache.calcite.sql.validate.SqlValidatorNamespace;
+
+import java.util.List;
+
+import static org.apache.flink.table.types.inference.TypeInferenceUtil.adaptArguments;
+import static org.apache.flink.table.types.inference.TypeInferenceUtil.createInvalidCallException;
+import static org.apache.flink.table.types.inference.TypeInferenceUtil.createInvalidInputException;
+import static org.apache.flink.table.types.inference.TypeInferenceUtil.createUnexpectedException;
+
+/**
+ * A {@link SqlOperandTypeChecker} backed by {@link TypeInference}.
+ *
+ * <p>Note: This class must be kept in sync with {@link TypeInferenceUtil}.
+ */
+@Internal
+public final class TypeInferenceOperandChecker implements SqlOperandTypeChecker {
+
+	private final FunctionDefinition definition;
+
+	private final TypeInference typeInference;
+
+	private final SqlOperandCountRange countRange;
+
+	public TypeInferenceOperandChecker(
+			FunctionDefinition definition,
+			TypeInference typeInference) {
+		this.definition = definition;
+		this.typeInference = typeInference;
+		this.countRange = new ArgumentCountRange(typeInference.getInputTypeStrategy().getArgumentCount());
+	}
+
+	@Override
+	public boolean checkOperandTypes(SqlCallBinding callBinding, boolean throwOnFailure) {
+		final CallContext callContext = new CallBindingCallContext(definition, callBinding, null);
+		try {
+			return checkOperandTypesOrError(callBinding, callContext);
+		}
+		catch (ValidationException e) {
+			if (throwOnFailure) {
+				throw createInvalidCallException(callContext, e);
+			}
+			return false;
+		} catch (Throwable t) {
+			throw createUnexpectedException(callContext, t);
+		}
+	}
+
+	@Override
+	public SqlOperandCountRange getOperandCountRange() {
+		return countRange;
+	}
+
+	@Override
+	public String getAllowedSignatures(SqlOperator op, String opName) {
+		return TypeInferenceUtil.generateSignature(opName, definition, typeInference);
+	}
+
+	@Override
+	public Consistency getConsistency() {
+		return Consistency.NONE;
+	}
+
+	@Override
+	public boolean isOptional(int i) {
+		return false;
+	}
+
+	// --------------------------------------------------------------------------------------------
+
+	private boolean checkOperandTypesOrError(SqlCallBinding callBinding, CallContext callContext) {
+		final AdaptedCallContext adaptedCallContext;
+		try {
+			adaptedCallContext = adaptArguments(
+				typeInference,
+				callContext,
+				null);
+		} catch (ValidationException e) {
+			throw createInvalidInputException(
+				typeInference,
+				callContext,
+				e);
+		}
+
+		insertImplicitCasts(callBinding, adaptedCallContext.getArgumentDataTypes());
+
+		return true;
+	}
+
+	private void insertImplicitCasts(SqlCallBinding callBinding, List<DataType> expectedDataTypes) {
+		final FlinkTypeFactory flinkTypeFactory = (FlinkTypeFactory) callBinding.getTypeFactory();
+		final List<SqlNode> operands = callBinding.operands();
+		for (int i = 0; i < operands.size(); i++) {
+			final LogicalType expectedType = expectedDataTypes.get(i).getLogicalType();
+			final RelDataType expectedRelDataType = flinkTypeFactory.createFieldTypeFromLogicalType(expectedType);
+
+			final SqlNode castedOperand = castTo(operands.get(i), expectedRelDataType);
+			callBinding.getCall().setOperand(i, castedOperand);
+			updateInferredType(callBinding.getValidator(), castedOperand, expectedRelDataType);
+		}
+	}
+
+	/**
+	 * Adopted from {@link org.apache.calcite.sql.validate.implicit.AbstractTypeCoercion}.
+	 */
+	private SqlNode castTo(SqlNode node, RelDataType type) {
+		return SqlStdOperatorTable.CAST.createCall(
+			SqlParserPos.ZERO,
+			node,
+			SqlTypeUtil.convertTypeToSpec(type).withNullable(type.isNullable()));
+	}
+
+	/**
+	 * Adopted from {@link org.apache.calcite.sql.validate.implicit.AbstractTypeCoercion}.
+	 */
+	@Deprecated
 
 Review comment:
   The deprecated annotation was also adopted from Calcite. But I will remove it as it causes confusion. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services