[jira] [Commented] (AIRFLOW-6645) Pass the TaskHandlers configuration using the constructor

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024074#comment-17024074 ] 

ASF GitHub Bot commented on AIRFLOW-6645:
-----------------------------------------

mik-laj commented on pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267
 
 
   It is difficult to understand the configurations of these classes if they contain hidden configuration options. I think that all configuration parameters should be passed by the constructor.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Pass the TaskHandlers configuration using the constructor
> ---------------------------------------------------------
>
>                 Key: AIRFLOW-6645
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6645
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: logging
>    Affects Versions: 1.10.7
>            Reporter: Kamil Bregula
>            Priority: Major
>
> It is difficult to understand the configurations of these classes if they contain hidden configuration options. All configuration parameters should be passed by the constructor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)