You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2012/11/10 00:59:12 UTC

[jira] [Created] (HBASE-7141) Cleanup Increment and Append issues

Lars Hofhansl created HBASE-7141:
------------------------------------

             Summary: Cleanup Increment and Append issues
                 Key: HBASE-7141
                 URL: https://issues.apache.org/jira/browse/HBASE-7141
             Project: HBase
          Issue Type: Bug
            Reporter: Lars Hofhansl
             Fix For: 0.96.0


* Append and Increment should take a TS for their update phase
* Append should access a timerange for the read phase
* Increment should no longer implement Writable (in trunk)

This depends on HBASE-4583

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7141) Cleanup Increment and Append issues

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495685#comment-13495685 ] 

Andrew Purtell commented on HBASE-7141:
---------------------------------------

bq.  I contemplated have Increment also maintain a map from CF -> Set of KV, but then there's unnecessary encoding at the client and decoding at the server. But maybe that is the right way to go.

+1, it's a reasonable tradeoff. Although, it would be enough for my purposed on HBASE-6222 for Increment to extend OperationWithAttributes.
                
> Cleanup Increment and Append issues
> -----------------------------------
>
>                 Key: HBASE-7141
>                 URL: https://issues.apache.org/jira/browse/HBASE-7141
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 0.96.0
>
>
> * Append and Increment should take a TS for their update phase
> * Append should access a timerange for the read phase
> * Increment should no longer implement Writable (in trunk)
> * Increment and Append makes changes visible through the memstore before the WAL is sync'ed
> This depends on HBASE-4583

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7141) Cleanup Increment and Append issues

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494742#comment-13494742 ] 

Andrew Purtell commented on HBASE-7141:
---------------------------------------

[~lhofhansl] Should we also look at HBASE-7114 at the same time?
                
> Cleanup Increment and Append issues
> -----------------------------------
>
>                 Key: HBASE-7141
>                 URL: https://issues.apache.org/jira/browse/HBASE-7141
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 0.96.0
>
>
> * Append and Increment should take a TS for their update phase
> * Append should access a timerange for the read phase
> * Increment should no longer implement Writable (in trunk)
> This depends on HBASE-4583

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-7141) Cleanup Increment and Append issues

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494776#comment-13494776 ] 

Lars Hofhansl commented on HBASE-7141:
--------------------------------------

Probably. The reason why I did not do that when I introduced Mutation was the the difference in which Increment handles its familyMap. All other mutations have a map from CF -> Set of KV. Increments maps from CF -> map of Column -> long.

If there's a good way to unify that, I'd love to do that. I contemplated have Increment also maintain a map from CF -> Set of KV, but then there's unnecessary encoding at the client and decoding at the server. But maybe that is the right way to go.

                
> Cleanup Increment and Append issues
> -----------------------------------
>
>                 Key: HBASE-7141
>                 URL: https://issues.apache.org/jira/browse/HBASE-7141
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 0.96.0
>
>
> * Append and Increment should take a TS for their update phase
> * Append should access a timerange for the read phase
> * Increment should no longer implement Writable (in trunk)
> This depends on HBASE-4583

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-7141) Cleanup Increment and Append issues

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-7141:
---------------------------------

    Description: 
* Append and Increment should take a TS for their update phase
* Append should access a timerange for the read phase
* Increment should no longer implement Writable (in trunk)
* Increment and Append makes changes visible through the memstore before the WAL is sync'ed

This depends on HBASE-4583

  was:
* Append and Increment should take a TS for their update phase
* Append should access a timerange for the read phase
* Increment should no longer implement Writable (in trunk)

This depends on HBASE-4583

    
> Cleanup Increment and Append issues
> -----------------------------------
>
>                 Key: HBASE-7141
>                 URL: https://issues.apache.org/jira/browse/HBASE-7141
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 0.96.0
>
>
> * Append and Increment should take a TS for their update phase
> * Append should access a timerange for the read phase
> * Increment should no longer implement Writable (in trunk)
> * Increment and Append makes changes visible through the memstore before the WAL is sync'ed
> This depends on HBASE-4583

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (HBASE-7141) Cleanup Increment and Append issues

Posted by "Andrew Purtell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495685#comment-13495685 ] 

Andrew Purtell edited comment on HBASE-7141 at 11/12/12 10:20 PM:
------------------------------------------------------------------

bq.  I contemplated have Increment also maintain a map from CF -> Set of KV, but then there's unnecessary encoding at the client and decoding at the server. But maybe that is the right way to go.

+1, it's a reasonable tradeoff. Although, it would be enough for my purposes on HBASE-6222 for Increment to extend OperationWithAttributes.
                
      was (Author: apurtell):
    bq.  I contemplated have Increment also maintain a map from CF -> Set of KV, but then there's unnecessary encoding at the client and decoding at the server. But maybe that is the right way to go.

+1, it's a reasonable tradeoff. Although, it would be enough for my purposed on HBASE-6222 for Increment to extend OperationWithAttributes.
                  
> Cleanup Increment and Append issues
> -----------------------------------
>
>                 Key: HBASE-7141
>                 URL: https://issues.apache.org/jira/browse/HBASE-7141
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>             Fix For: 0.96.0
>
>
> * Append and Increment should take a TS for their update phase
> * Append should access a timerange for the read phase
> * Increment should no longer implement Writable (in trunk)
> * Increment and Append makes changes visible through the memstore before the WAL is sync'ed
> This depends on HBASE-4583

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira