You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2019/02/12 05:10:00 UTC
[jira] [Commented] (ARROW-4382) [C++] Improve new cpplint output
readability
[ https://issues.apache.org/jira/browse/ARROW-4382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16765682#comment-16765682 ]
Wes McKinney commented on ARROW-4382:
-------------------------------------
I fixed this bug in my patch for ARROW-47
> [C++] Improve new cpplint output readability
> --------------------------------------------
>
> Key: ARROW-4382
> URL: https://issues.apache.org/jira/browse/ARROW-4382
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Affects Versions: 0.12.0
> Reporter: Wes McKinney
> Assignee: Wes McKinney
> Priority: Major
> Fix For: 0.13.0
>
>
> The output is bring printed as a __repr__ so the line breaks don't render properly
> {code}
> cd /home/wesm/code/arrow/cpp/preflight-build && /home/wesm/miniconda/envs/arrow-3.7/bin/python /home/wesm/code/arrow/cpp/build-support/run_cpplint.py --cpplint_binary /home/wesm/code/arrow/cpp/build-support/cpplint.py --exclude_globs /home/wesm/code/arrow/cpp/build-support/lint_exclusions.txt --source_dir /home/wesm/code/arrow/cpp/src --quiet
> b'/home/wesm/code/arrow/cpp/src/parquet/schema.cc:68: Add #include <algorithm> for copy [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/schema.cc:71: Add #include <utility> for move [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/file_writer.cc:225: Add #include <vector> for vector<> [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/file_writer.cc:390: Add #include <utility> for move [build/include_what_you_use] [4]\n'
> b'/home/wesm/code/arrow/cpp/src/parquet/arrow/record_reader.cc:897: Add #include <utility> for move [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/arrow/writer.cc:1117: Add #include <utility> for move [build/include_what_you_use] [4]\n/home/wesm/code/arrow/cpp/src/parquet/arrow/reader.cc:1552: Add #include <utility> for move [build/include_what_you_use] [4]\n'
> /home/wesm/code/arrow/cpp/src/parquet/file_writer.cc: had cpplint issues
> /home/wesm/code/arrow/cpp/src/parquet/schema.cc: had cpplint issues
> /home/wesm/code/arrow/cpp/src/parquet/arrow/record_reader.cc: had cpplint issues
> /home/wesm/code/arrow/cpp/src/parquet/arrow/writer.cc: had cpplint issues
> /home/wesm/code/arrow/cpp/src/parquet/arrow/reader.cc: had cpplint issues
> ninja: build stopped: subcommand failed.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)