[GitHub] [trafficcontrol] mitchell852 opened a new pull request #4178: TP: limits delivery serivce cloning to source ds type = target ds type

[GitBox <gi...@apache.org>]

mitchell852 opened a new pull request #4178: TP: limits delivery serivce cloning to source ds type = target ds type
URL: https://github.com/apache/trafficcontrol/pull/4178
 
 
   ## What does this PR (Pull Request) do?
   
   - [x] This PR fixes #3403 
   
   because different ds "categories" (anymap, dns, http or steering) have different attributes, cloning a ds needs to be limited where source ds and target ds have the same category.
   
   for example, you should not be able to clone a DNS ds to an ANY_MAP ds because that would add attributes to the any map ds that are not applicable (i.e. origin fqdn).
   
   ## Which Traffic Control components are affected by this PR?
   
   - Traffic Portal
   
   ## What is the best way to verify this PR?
   - navigate to a ds
   - click More > Clone Delivery Service
   
   you no longer have the option to choose the category of the target ds. Instead, the type of the source ds will be used to create the clone, however, that type can be changed but must be within a "category". Here are the categories and associated types:
   
   DNS
   - DNS
   - DNS_LIVE
   - DNS_LIVE_NATNL
   
   HTTP
   - HTTP
   - HTTP_LIVE
   - HTTP_LIVE_NATNL
   - HTTP_NO_CACHE
   
   ANY_MAP
   
   STEERING
   - STEERING
   - CLIENT_STEERING
   
   With this change you can no longer clone ds's across categories. You must stay within the category of the source ds.
   
   ## The following criteria are ALL met by this PR
   
   - [ ] This PR includes tests OR I have explained why tests are unnecessary
   - [ ] This PR includes documentation OR I have explained why documentation is unnecessary
   - [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [ ] This PR includes any and all required license headers
   - [ ] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [ ] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services