You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Adam Crume (JIRA)" <ji...@apache.org> on 2007/10/23 17:39:41 UTC

[jira] Updated: (WW-2255) Field validators should be skipped if there is a conversion error

     [ https://issues.apache.org/struts/browse/WW-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Crume updated WW-2255:
---------------------------

    Attachment: ConversionErrorInterceptor2.java

It's not elegant, but this can be achieved by removing the old conversionError interceptor and adding this modified one *after* the validation interceptor.  It works by overwriting any validation error messages a field has if it has a conversion error.

I had to copy and modify the code in org.apache.struts2.interceptor.StrutsConversionErrorInterceptor and com.opensymphony.xwork2.interceptor.ConversionErrorInterceptor because the logic couldn't be changed easily by subclassing.

> Field validators should be skipped if there is a conversion error
> -----------------------------------------------------------------
>
>                 Key: WW-2255
>                 URL: https://issues.apache.org/struts/browse/WW-2255
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Validation
>            Reporter: Adam Crume
>         Attachments: ConversionErrorInterceptor2.java
>
>
> If there is an error converting a field, the validators for that field should be skipped.  For example, let's say I have an action with an "age" field declared as an Integer, and the field is required.  If the user enters "one", the user will see two errors: one from the conversion process, and one from the required validator (since the field was never assigned).
> In general, a conversion error should short-circuit all validators for that field, since validators depend on the field being set, which never happens if there was a conversion error.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.