You are viewing a plain text version of this content. The canonical link for it is here.

Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/05/30 05:59:27 UTC

[GitHub] [hadoop] bshashikant commented on issue #846: HDDS-1555. Disable install snapshot for ContainerStateMachine.

bshashikant commented on issue #846: HDDS-1555. Disable install snapshot for ContainerStateMachine.
URL: https://github.com/apache/hadoop/pull/846#issuecomment-497213904
 
 
   Thanks @swagle for working on this. The changes look good. I have just one point to make here:
   Add a javadoc/comments for handleInstallSnapshotFromLeader() specifying the reason to close down the pipeline as well for disabling the installSnapshotEnabled in the code.
   
   I am +1 after that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org