You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by eowhadi <gi...@git.apache.org> on 2017/01/02 18:39:42 UTC

[GitHub] incubator-trafodion pull request #900: [TRAFODION-2422]

GitHub user eowhadi opened a pull request:

    https://github.com/apache/incubator-trafodion/pull/900

    [TRAFODION-2422]

    populateSortCols was flagged as major perf offender during profiling
    the reason being an unbound iterative string search on huge string.
    Added a minor fix: When not setting category in log conf file, extra code is executed, potentially impacting performance

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/eowhadi/incubator-trafodion slowCompileFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-trafodion/pull/900.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #900
    
----
commit b7f483f49914036c2224e5c00f8a84755e90d9b6
Author: Eric Owhadi <er...@esgyn.com>
Date:   2017-01-02T18:32:05Z

    [TRAFODION-2422]
    populateSortCols was flagged as major perf offender during profiling
    the reason being an unbound iterative string search on huge string.
    Added a minor fix: When not setting category in log conf file, extra code is executed, potentially impacting performance

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #900: [TRAFODION-2422]

Posted by zellerh <gi...@git.apache.org>.
Github user zellerh commented on a diff in the pull request:

    https://github.com/apache/incubator-trafodion/pull/900#discussion_r94516660
  
    --- Diff: core/sql/executor/hiveHook.cpp ---
    @@ -468,7 +468,8 @@ struct hive_skey_desc* populateSortCols(HiveMetaData *md, Int32 sdID,
                       "populateSortCols::sortCols:],###"))
         return NULL;
       
    -  
    +  if ((foundE - pos)<=10) //this is important to avoid major performance impact when looking for non existent Order(col over and over, parsing to the end of string. hot spot flagged using gprof
    --- End diff --
    
    Would be good to add a comment here that we are testing for the string sortCols:[], which happens to be 10 characters long. Or, better to use strlen("sortCols:[]").


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafodion pull request #900: [TRAFODION-2422]

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-trafodion/pull/900


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---