You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/07/12 12:24:37 UTC
[Impala-ASF-CR] IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17675
Change subject: IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
......................................................................
IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
statestore_subscriber_timeout_secs is also an important flag for
statestore scalability. Especially when the heartbeat frequency and
timeout are bumpped up, this flag should also be bumpped as well.
To introduce this flag, we should also introduce the heartbeat tcp
timeout flag and the max missed heartbeat flag.
Tests:
- Built locally, verify the html and pdf artifacts are expected.
Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
---
M docs/topics/impala_scalability.xml
1 file changed, 65 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/75/17675/1
--
To view, visit http://gerrit.cloudera.org:8080/17675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Gerrit-Change-Number: 17675
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17675 )
Change subject: IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/638/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/17675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Gerrit-Change-Number: 17675
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Jul 2021 12:24:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17675 )
Change subject: IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
......................................................................
IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
statestore_subscriber_timeout_secs is also an important flag for
statestore scalability. Especially when the heartbeat frequency and
timeout are bumpped up, this flag should also be bumpped as well.
To introduce this flag, we should also introduce the heartbeat tcp
timeout flag and the max missed heartbeat flag.
Tests:
- Built locally, verify the html and pdf artifacts are expected.
Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Reviewed-on: http://gerrit.cloudera.org:8080/17675
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Shajini Thayasingh <st...@cloudera.com>
Reviewed-by: Tamas Mate <tm...@cloudera.com>
---
M docs/topics/impala_scalability.xml
1 file changed, 65 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Shajini Thayasingh: Looks good to me, but someone else must approve
Tamas Mate: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Gerrit-Change-Number: 17675
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17675 )
Change subject: IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
......................................................................
Patch Set 1: Code-Review+2
Thanks for updating the docs with this Quanlong. LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/17675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Gerrit-Change-Number: 17675
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Jul 2021 06:09:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17675 )
Change subject: IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
......................................................................
Patch Set 1:
Thank Tamas and Shajini for review. Merging this.
--
To view, visit http://gerrit.cloudera.org:8080/17675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Gerrit-Change-Number: 17675
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 17 Jul 2021 01:35:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17675 )
Change subject: IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/638/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/17675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Gerrit-Change-Number: 17675
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Jul 2021 12:32:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
Posted by "Shajini Thayasingh (Code Review)" <ge...@cloudera.org>.
Shajini Thayasingh has posted comments on this change. ( http://gerrit.cloudera.org:8080/17675 )
Change subject: IMPALA-10788: [DOCS] Introduce more flags for Statestore Scalability
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/17675
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4b331693c5c0945f4cec8fd81ed9ec688563333
Gerrit-Change-Number: 17675
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Shajini Thayasingh <st...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Jul 2021 16:56:34 +0000
Gerrit-HasComments: No