You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "zabetak (via GitHub)" <gi...@apache.org> on 2025/12/02 12:02:44 UTC
[PR] HIVE-28885: Disable unnecessary annotation processing [hive]
zabetak opened a new pull request, #6221:
URL: https://github.com/apache/hive/pull/6221
### What changes were proposed in this pull request?
1. Disable annotation processors from all modules that do not need them.
2. Decouple immutables processor from errorprone processor and move immutables processor in iceberg-catalog module since it is only user there.
### Why are the changes needed?
Except iceberg, all the other modules do not need annotation processors. However, the log4j-core dependency contains an annotation processor and this has impact on the build leading to maven WARNING messages and the deactivation of compile avoidance.
```
[WARNING] The following annotation processors were found on the classpath:
[org.apache.logging.log4j.core.config.plugins.processor.PluginProcessor], provided by /home/someuser/.m2/repository/org/apache/logging/log4j/log4j-core/2.24.3/log4j-core-2.24.3.jar
Compile avoidance has been deactivated.
Please use the maven-compiler-plugin version 3.5 or above and use the <annotationProcessorPaths> configuration element to declare the processors instead.
If you did not intend to use the processors above (e.g. they were leaked by a dependency), you can use the <proc>none</proc> option to disable annotation processing.
For more information see https://gradle.com/help/maven-extension-compile-avoidance.
```
Apart from compile avoidance the use of annotation processing can have other side effects during the build and it can even lead to cryptic compilation failures.
### Does this PR introduce any user-facing change?
No
### Is the change a dependency upgrade?
No
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28885: Disable unnecessary annotation processing [hive]
Posted by "Aggarwal-Raghav (via GitHub)" <gi...@apache.org>.
Aggarwal-Raghav commented on PR #6221:
URL: https://github.com/apache/hive/pull/6221#issuecomment-3606427342
LGTM +1 (non-binding)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28885: Disable unnecessary annotation processing [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak merged PR #6221:
URL: https://github.com/apache/hive/pull/6221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28885: Disable unnecessary annotation processing [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #6221:
URL: https://github.com/apache/hive/pull/6221#issuecomment-3610874079
Many thanks for the reviews @deniskuzZ and @Aggarwal-Raghav !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28885: Disable unnecessary annotation processing [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #6221:
URL: https://github.com/apache/hive/pull/6221#issuecomment-3602474221
There are test failures that are relevant to the changes so I need to take a look. For the time being, I will switch the status to DRAFT.
```
Testing / split-06 / PostProcess / testQueryRoutingLogFileNameOnIncompleteQuery(LlapDaemon, DoNothingTCPServer) – org.apache.hadoop.hive.llap.daemon.impl.TestLlapDaemonLogging
11s
Testing / split-06 / PostProcess / testQueryRoutingLogFileNameOnCompleteQuery(LlapDaemon, DoNothingTCPServer) – org.apache.hadoop.hive.llap.daemon.impl.TestLlapDaemonLogging
18s
Testing / split-01 / PostProcess / testSlidingLogFiles – org.apache.hadoop.hive.ql.log.TestSlidingFilenameRolloverStrategy
<1s
Testing / split-17 / PostProcess / slf4jReporter – org.apache.hadoop.hive.metastore.metrics.TestMetrics
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28885: Disable unnecessary annotation processing [hive]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak commented on PR #6221:
URL: https://github.com/apache/hive/pull/6221#issuecomment-3602887113
OK, I found the reason for the failures so I am hoping that the next run will come completely green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28885: Disable unnecessary annotation processing [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6221:
URL: https://github.com/apache/hive/pull/6221#issuecomment-3601940273
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6221) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6221&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6221&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6221&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6221&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6221&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6221)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
Re: [PR] HIVE-28885: Disable unnecessary annotation processing [hive]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #6221:
URL: https://github.com/apache/hive/pull/6221#issuecomment-3603271559
## [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6221) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6221&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=6221&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=6221&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6221&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=6221&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=6221)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org