You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/13 11:45:00 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #32149: [SPARK-28227][SQL][FOLLOWUP] Add test case about transform expression with `distinct`

cloud-fan commented on a change in pull request #32149:
URL: https://github.com/apache/spark/pull/32149#discussion_r612370686



##########
File path: sql/core/src/test/resources/sql-tests/results/transform.sql.out
##########
@@ -638,3 +639,15 @@ struct<b:string>
 1
 2
 3
+
+
+-- !query
+SELECT TRANSFORM(distinct b, a, c)

Review comment:
       ah the parser treats it as `distinct as b`.
   
   Can we improve the parser to recognize `distinct` correctly and give a clear error message?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org