You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/13 11:21:01 UTC

[GitHub] [pulsar] AnonHxy commented on a diff in pull request #15554: [improve][broker]Remove repeated subscribeRateLimiter update

AnonHxy commented on code in PR #15554:
URL: https://github.com/apache/pulsar/pull/15554#discussion_r872293523


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -2430,10 +2430,6 @@ public CompletableFuture<Void> onPoliciesUpdate(Policies data) {
                 CompletableFuture<Void> persistentPoliciesFuture = checkPersistencePolicies();
                 // update rate-limiter if policies updated
                 dispatchRateLimiter.ifPresent(DispatchRateLimiter::updateDispatchRate);
-                if (this.subscribeRateLimiter.isPresent()) {

Review Comment:
   `subscribeRateLimiter` has been updated in the method `initializeRateLimiterIfNeeded`,  which is located at      https://github.com/apache/pulsar/blob/61d5a5dda39a407a8fb2464a0056f38b516e07ca/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L2400



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org