You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/05/25 08:10:25 UTC
[jira] [Created] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Harsh J created HADOOP-8434:
-------------------------------
Summary: TestConfiguration currently has no tests for direct setter methods
Key: HADOOP-8434
URL: https://issues.apache.org/jira/browse/HADOOP-8434
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Harsh J
Jan van der Lugt noticed this on HADOOP-8415.
bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8434:
------------------------------------
Issue Type: Test (was: Bug)
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8434:
------------------------------------
Attachment: HADOOP-8434-2.patch
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8434:
------------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed the patch. Thank you Madhukara for providing the patch.
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "madhukara phatak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
madhukara phatak reassigned HADOOP-8434:
----------------------------------------
Assignee: madhukara phatak
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "madhukara phatak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
madhukara phatak updated HADOOP-8434:
-------------------------------------
Attachment: (was: HADOOP-8434.patch)
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "madhukara phatak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
madhukara phatak updated HADOOP-8434:
-------------------------------------
Attachment: HADOOP-8434-1.patch
updated patch according to the code-style convention
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434-1.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "madhukara phatak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
madhukara phatak updated HADOOP-8434:
-------------------------------------
Attachment: HADOOP-8434.patch
Added test cases for explicit set methods.
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406686#comment-13406686 ]
Hudson commented on HADOOP-8434:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2422 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2422/])
HADOOP-8434. Add tests for Configuration setter methods. Contributed by Madhukara Phatak. (Revision 1356864)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356864
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "madhukara phatak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
madhukara phatak updated HADOOP-8434:
-------------------------------------
Status: Patch Available (was: Open)
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407134#comment-13407134 ]
Hudson commented on HADOOP-8434:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1127 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1127/])
HADOOP-8434. Add tests for Configuration setter methods. Contributed by Madhukara Phatak. (Revision 1356864)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356864
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406740#comment-13406740 ]
Hudson commented on HADOOP-8434:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2439 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2439/])
HADOOP-8434. Add tests for Configuration setter methods. Contributed by Madhukara Phatak. (Revision 1356864)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356864
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13407010#comment-13407010 ]
Hudson commented on HADOOP-8434:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1094 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1094/])
HADOOP-8434. Add tests for Configuration setter methods. Contributed by Madhukara Phatak. (Revision 1356864)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356864
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406694#comment-13406694 ]
Hudson commented on HADOOP-8434:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2490 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2490/])
HADOOP-8434. Add tests for Configuration setter methods. Contributed by Madhukara Phatak. (Revision 1356864)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1356864
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Fix For: 3.0.0
>
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284673#comment-13284673 ]
Hadoop QA commented on HADOOP-8434:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12529853/HADOOP-8434.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.viewfs.TestViewFsTrash
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1045//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1045//console
This message is automatically generated.
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "madhukara phatak (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
madhukara phatak updated HADOOP-8434:
-------------------------------------
Attachment: HADOOP-8434.patch
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13405966#comment-13405966 ]
Suresh Srinivas commented on HADOOP-8434:
-----------------------------------------
Made a minor update to the patch - line was more than 80 columns and removed unnecessary IOExceptions (throws in the existing code and not in the code from the patch).
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434-1.patch, HADOOP-8434-2.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285483#comment-13285483 ]
Hadoop QA commented on HADOOP-8434:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12530175/HADOOP-8434-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1056//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1056//console
This message is automatically generated.
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434-1.patch, HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8434) TestConfiguration currently has no
tests for direct setter methods
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285448#comment-13285448 ]
Harsh J commented on HADOOP-8434:
---------------------------------
Thanks for the patch. I have just one code-style related nit:
bq. assertEquals(value,configuration.getBoolean("value",false));
As seen in the above example, please provide spaces between arguments as per the Sun coding guidelines we follow for Apache Hadoop.
Otherwise, looks good. +1 pending new patch and a jenkins re-run.
> TestConfiguration currently has no tests for direct setter methods
> ------------------------------------------------------------------
>
> Key: HADOOP-8434
> URL: https://issues.apache.org/jira/browse/HADOOP-8434
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: madhukara phatak
> Labels: newbie
> Attachments: HADOOP-8434.patch
>
>
> Jan van der Lugt noticed this on HADOOP-8415.
> bq. Just FYI, there are no tests for setFloat, setInt, setLong, etc. Might be better to add all of those at the same time.
> Would be good to have (coverage-wise first, regression-wise second) explicit tests for the each of the setter methods, although other projects' tests do test this extensively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira