You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by Gale Naylor <Ga...@noventussolutions.com> on 2016/08/03 18:48:57 UTC
CWL code questions
I have a couple of questions about the CWL code.
(1) In CwlServiceDesc.java, line 50:
Should CwlDumyActivity.class be called CwlDummyActivity.class?
(Because it looks like the code creates a "dummy" class.)
(2) In CwlServiceProvider.java, lines 47 and 48:
Should the constant names be upper case? e.g., PROVIDER_NAME and
PROVIDER_ID?
Thanks!
Gale
Re: CWL code questions
Posted by Thilina Manamgoda <ma...@gmail.com>.
Hi Gale,
I think you are looking at older branch. This is the new branch
https://github.com/ThilinaManamgoda/incubator-taverna-common-activities/tree/taverna-3.
If you can put suggestions on GitHub also that would be great
regards,
Thilina.
On Sat, Aug 6, 2016 at 2:30 AM, Gale Naylor <Ga...@noventussolutions.com>
wrote:
> Hi Alan,
>
> Thank you for the explanation and the link. It makes much more sense now.
>
> Gale
>
> On Fri, Aug 5, 2016 at 1:23 PM Alan Williams <al...@googlemail.com>
> wrote:
>
> > On 05-Aug-16 18:42, Gale Naylor wrote:
> >
> > Hello Gale
> >
> > > In CwlContextualView.java (I used the wrong filename in my previous
> > email)
> > > I'm also curious about the two private, final (but not static)
> constants
> > > (?): configurationBean and activity.
> > >
> > > I'm not sure this StackOverflow answer is 100% relevant because
> > > configurationBean and activity do not have initial values, but this is
> > all
> > > I've been able to find online:
> > >
> > http://stackoverflow.com/questions/1415955/private-
> final-static-attribute-vs-private-final-attribute
> >
> > If an attribute is not static then each instance of the class has its
> > own attribute. So,
> >
> > private final CwlActivityConfigurationBean configurationBean;
> >
> > means that each CwlContextualView has its own configurationBean value.
> >
> > If an attribute is declared as static, then all instances of the class
> > share the same attribute value.
> >
> > The private means that the value of the configurationBean cannot be
> > accessed (directly) outside of the CwlContextualView. So
> >
> > fred = myCwlContextualView.configurationBean // will not work
> >
> > The final means that once the attribute has a value it cannot be
> > changed. Even stronger, the value must be specified either in the
> > declaration of the attribute, or when you construct an instance of
> > CwlContextualView. (There are weird exceptions to the last sentence that
> > are best ignored and never mentioned in polite company.)
> >
> > If you look at
> >
> > public CwlContextualView(CwlDumyActivity activity)
> >
> > which makes a CwlContextualView, it contains the line:
> >
> > this.configurationBean = activity.getConfiguration();
> >
> > So once you have made a CwlConfigurationView, it has a configurationBean
> > attribute, that nothing else can see, and that has a fixed value.
> >
> > > Can anyone point me to information that would help me understand this
> > > nomenclature?
> >
> > I think
> >
> > http://stackoverflow.com/questions/13772827/difference-
> between-static-and-final
> > explains static and final well.
> >
> > > Thanks,
> > >
> > > Gale
> >
> > Alan
> >
> >
>
Re: CWL code questions
Posted by Gale Naylor <Ga...@noventussolutions.com>.
Hi Alan,
Thank you for the explanation and the link. It makes much more sense now.
Gale
On Fri, Aug 5, 2016 at 1:23 PM Alan Williams <al...@googlemail.com>
wrote:
> On 05-Aug-16 18:42, Gale Naylor wrote:
>
> Hello Gale
>
> > In CwlContextualView.java (I used the wrong filename in my previous
> email)
> > I'm also curious about the two private, final (but not static) constants
> > (?): configurationBean and activity.
> >
> > I'm not sure this StackOverflow answer is 100% relevant because
> > configurationBean and activity do not have initial values, but this is
> all
> > I've been able to find online:
> >
> http://stackoverflow.com/questions/1415955/private-final-static-attribute-vs-private-final-attribute
>
> If an attribute is not static then each instance of the class has its
> own attribute. So,
>
> private final CwlActivityConfigurationBean configurationBean;
>
> means that each CwlContextualView has its own configurationBean value.
>
> If an attribute is declared as static, then all instances of the class
> share the same attribute value.
>
> The private means that the value of the configurationBean cannot be
> accessed (directly) outside of the CwlContextualView. So
>
> fred = myCwlContextualView.configurationBean // will not work
>
> The final means that once the attribute has a value it cannot be
> changed. Even stronger, the value must be specified either in the
> declaration of the attribute, or when you construct an instance of
> CwlContextualView. (There are weird exceptions to the last sentence that
> are best ignored and never mentioned in polite company.)
>
> If you look at
>
> public CwlContextualView(CwlDumyActivity activity)
>
> which makes a CwlContextualView, it contains the line:
>
> this.configurationBean = activity.getConfiguration();
>
> So once you have made a CwlConfigurationView, it has a configurationBean
> attribute, that nothing else can see, and that has a fixed value.
>
> > Can anyone point me to information that would help me understand this
> > nomenclature?
>
> I think
>
> http://stackoverflow.com/questions/13772827/difference-between-static-and-final
> explains static and final well.
>
> > Thanks,
> >
> > Gale
>
> Alan
>
>
Re: CWL code questions
Posted by Alan Williams <al...@googlemail.com>.
On 05-Aug-16 18:42, Gale Naylor wrote:
Hello Gale
> In CwlContextualView.java (I used the wrong filename in my previous email)
> I'm also curious about the two private, final (but not static) constants
> (?): configurationBean and activity.
>
> I'm not sure this StackOverflow answer is 100% relevant because
> configurationBean and activity do not have initial values, but this is all
> I've been able to find online:
> http://stackoverflow.com/questions/1415955/private-final-static-attribute-vs-private-final-attribute
If an attribute is not static then each instance of the class has its
own attribute. So,
private final CwlActivityConfigurationBean configurationBean;
means that each CwlContextualView has its own configurationBean value.
If an attribute is declared as static, then all instances of the class
share the same attribute value.
The private means that the value of the configurationBean cannot be
accessed (directly) outside of the CwlContextualView. So
fred = myCwlContextualView.configurationBean // will not work
The final means that once the attribute has a value it cannot be
changed. Even stronger, the value must be specified either in the
declaration of the attribute, or when you construct an instance of
CwlContextualView. (There are weird exceptions to the last sentence that
are best ignored and never mentioned in polite company.)
If you look at
public CwlContextualView(CwlDumyActivity activity)
which makes a CwlContextualView, it contains the line:
this.configurationBean = activity.getConfiguration();
So once you have made a CwlConfigurationView, it has a configurationBean
attribute, that nothing else can see, and that has a fixed value.
> Can anyone point me to information that would help me understand this
> nomenclature?
I think
http://stackoverflow.com/questions/13772827/difference-between-static-and-final
explains static and final well.
> Thanks,
>
> Gale
Alan
Re: CWL code questions
Posted by GaleN <Ga...@noventussolutions.com>.
Got it, Michael! Thanks, I misread the user guide. And thanks for the
detailed link!
On Tue, Aug 9, 2016 at 9:32 AM GaleN <Ga...@noventussolutions.com> wrote:
> Thanks for explaining the process you use, Ian.
>
> This is from GitHub help, but doesn't seem any easier than the way you
> described:
> https://help.github.com/articles/commenting-on-differences-between-files/.
>
> On Tue, Aug 9, 2016 at 9:29 AM Michael Crusoe <mi...@gmail.com>
> wrote:
>
>> Happy to clarify. The detailed (and rather hard to read, we apologize)
>> full
>> specification is at http://www.commonwl.org/v1.0/CommandLineTool.html
>>
>> In this instance the user guide is (correctly) referring to the
>> construction of the command line. I was referring to the order of the
>> fields within a CWL document which is what I think you were also talking
>> about.
>>
>> On Tue, Aug 9, 2016 at 7:18 PM, GaleN <Ga...@noventussolutions.com>
>> wrote:
>>
>> > Hi Michael, thank you for the clarification! I was only going by "A
>> Gentle
>> > Introduction to the Common Workflow Language" (see link below). I'm
>> > (obviously) new to CWL and don't yet know which resources are most
>> > accurate, so thanks for jumping in to correct me!
>> >
>> > Thilina, What I meant was that the very last line at the end of section
>> 2.2
>> > in http://www.commonwl.org/draft-3/UserGuide.html says:
>> >
>> > "The baseCommand field always comes before parameters."
>> >
>> > However, Michael has clarified that the order doesn't matter.
>> >
>> > Gale
>> >
>> > On Tue, Aug 9, 2016 at 9:11 AM GaleN <Ga...@noventussolutions.com>
>> wrote:
>> >
>> > > Yes, I was looking at the older branch. I'll put future suggestions on
>> > > GitHub.
>> > >
>> > > On Fri, Aug 5, 2016, 10:10 PM Thilina Manamgoda <
>> maanafunedu@gmail.com>
>> > > wrote:
>> > >
>> > >> Hi,
>> > >>
>> > >> Yes it should. What you meant by "Also, I notice in this CWL User
>> > Guide (
>> > >> http://www.commonwl.org/draft-3/UserGuide.html ) it says the
>> > basecommand
>> > >> field comes before the input and output parameters." ?
>> > >>
>> > >> Thilina.
>> > >>
>> > >
>> >
>>
>>
>>
>> --
>> Michael R. Crusoe
>> Community Engineer & Co-founder
>> Common Workflow Language project
>> https://impactstory.org/u/0000-0002-2961-9670
>> michael.crusoe@gmail.com
>> +40 720 781 765
>> +1 480 627 9108
>>
>
Re: CWL code questions
Posted by GaleN <Ga...@noventussolutions.com>.
Thanks for explaining the process you use, Ian.
This is from GitHub help, but doesn't seem any easier than the way you
described:
https://help.github.com/articles/commenting-on-differences-between-files/.
On Tue, Aug 9, 2016 at 9:29 AM Michael Crusoe <mi...@gmail.com>
wrote:
> Happy to clarify. The detailed (and rather hard to read, we apologize) full
> specification is at http://www.commonwl.org/v1.0/CommandLineTool.html
>
> In this instance the user guide is (correctly) referring to the
> construction of the command line. I was referring to the order of the
> fields within a CWL document which is what I think you were also talking
> about.
>
> On Tue, Aug 9, 2016 at 7:18 PM, GaleN <Ga...@noventussolutions.com> wrote:
>
> > Hi Michael, thank you for the clarification! I was only going by "A
> Gentle
> > Introduction to the Common Workflow Language" (see link below). I'm
> > (obviously) new to CWL and don't yet know which resources are most
> > accurate, so thanks for jumping in to correct me!
> >
> > Thilina, What I meant was that the very last line at the end of section
> 2.2
> > in http://www.commonwl.org/draft-3/UserGuide.html says:
> >
> > "The baseCommand field always comes before parameters."
> >
> > However, Michael has clarified that the order doesn't matter.
> >
> > Gale
> >
> > On Tue, Aug 9, 2016 at 9:11 AM GaleN <Ga...@noventussolutions.com>
> wrote:
> >
> > > Yes, I was looking at the older branch. I'll put future suggestions on
> > > GitHub.
> > >
> > > On Fri, Aug 5, 2016, 10:10 PM Thilina Manamgoda <maanafunedu@gmail.com
> >
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> Yes it should. What you meant by "Also, I notice in this CWL User
> > Guide (
> > >> http://www.commonwl.org/draft-3/UserGuide.html ) it says the
> > basecommand
> > >> field comes before the input and output parameters." ?
> > >>
> > >> Thilina.
> > >>
> > >
> >
>
>
>
> --
> Michael R. Crusoe
> Community Engineer & Co-founder
> Common Workflow Language project
> https://impactstory.org/u/0000-0002-2961-9670
> michael.crusoe@gmail.com
> +40 720 781 765
> +1 480 627 9108
>
Re: CWL code questions
Posted by Michael Crusoe <mi...@gmail.com>.
Happy to clarify. The detailed (and rather hard to read, we apologize) full
specification is at http://www.commonwl.org/v1.0/CommandLineTool.html
In this instance the user guide is (correctly) referring to the
construction of the command line. I was referring to the order of the
fields within a CWL document which is what I think you were also talking
about.
On Tue, Aug 9, 2016 at 7:18 PM, GaleN <Ga...@noventussolutions.com> wrote:
> Hi Michael, thank you for the clarification! I was only going by "A Gentle
> Introduction to the Common Workflow Language" (see link below). I'm
> (obviously) new to CWL and don't yet know which resources are most
> accurate, so thanks for jumping in to correct me!
>
> Thilina, What I meant was that the very last line at the end of section 2.2
> in http://www.commonwl.org/draft-3/UserGuide.html says:
>
> "The baseCommand field always comes before parameters."
>
> However, Michael has clarified that the order doesn't matter.
>
> Gale
>
> On Tue, Aug 9, 2016 at 9:11 AM GaleN <Ga...@noventussolutions.com> wrote:
>
> > Yes, I was looking at the older branch. I'll put future suggestions on
> > GitHub.
> >
> > On Fri, Aug 5, 2016, 10:10 PM Thilina Manamgoda <ma...@gmail.com>
> > wrote:
> >
> >> Hi,
> >>
> >> Yes it should. What you meant by "Also, I notice in this CWL User
> Guide (
> >> http://www.commonwl.org/draft-3/UserGuide.html ) it says the
> basecommand
> >> field comes before the input and output parameters." ?
> >>
> >> Thilina.
> >>
> >
>
--
Michael R. Crusoe
Community Engineer & Co-founder
Common Workflow Language project
https://impactstory.org/u/0000-0002-2961-9670
michael.crusoe@gmail.com
+40 720 781 765
+1 480 627 9108
Re: CWL code questions
Posted by GaleN <Ga...@noventussolutions.com>.
Hi Michael, thank you for the clarification! I was only going by "A Gentle
Introduction to the Common Workflow Language" (see link below). I'm
(obviously) new to CWL and don't yet know which resources are most
accurate, so thanks for jumping in to correct me!
Thilina, What I meant was that the very last line at the end of section 2.2
in http://www.commonwl.org/draft-3/UserGuide.html says:
"The baseCommand field always comes before parameters."
However, Michael has clarified that the order doesn't matter.
Gale
On Tue, Aug 9, 2016 at 9:11 AM GaleN <Ga...@noventussolutions.com> wrote:
> Yes, I was looking at the older branch. I'll put future suggestions on
> GitHub.
>
> On Fri, Aug 5, 2016, 10:10 PM Thilina Manamgoda <ma...@gmail.com>
> wrote:
>
>> Hi,
>>
>> Yes it should. What you meant by "Also, I notice in this CWL User Guide (
>> http://www.commonwl.org/draft-3/UserGuide.html ) it says the basecommand
>> field comes before the input and output parameters." ?
>>
>> Thilina.
>>
>
Re: CWL code questions
Posted by GaleN <Ga...@noventussolutions.com>.
Yes, I was looking at the older branch. I'll put future suggestions on
GitHub.
On Fri, Aug 5, 2016, 10:10 PM Thilina Manamgoda <ma...@gmail.com>
wrote:
> Hi,
>
> Yes it should. What you meant by "Also, I notice in this CWL User Guide (
> http://www.commonwl.org/draft-3/UserGuide.html ) it says the basecommand
> field comes before the input and output parameters." ?
>
> Thilina.
>
Re: CWL code questions
Posted by Michael Crusoe <mi...@gmail.com>.
There is no required order for `baseCommand`, `inputs`, `class`,
`cwlVersion`, and so forth. They are allowed to be in any order.
On Sat, Aug 6, 2016 at 8:10 AM, Thilina Manamgoda <ma...@gmail.com>
wrote:
> Hi,
>
> Yes it should. What you meant by "Also, I notice in this CWL User Guide (
> http://www.commonwl.org/draft-3/UserGuide.html ) it says the basecommand
> field comes before the input and output parameters." ?
>
> Thilina.
>
--
Michael R. Crusoe
Community Engineer & Co-founder
Common Workflow Language project
https://impactstory.org/u/0000-0002-2961-9670
michael.crusoe@gmail.com
+40 720 781 765
+1 480 627 9108
Re: CWL code questions
Posted by Ian Dunlop <ia...@gmail.com>.
Hello,
As a slight aside, I've never quite figured out how to comment on the
actual code in a default branch in github. I can only comment on an actual
revision using the 'history' button for a file, then clicking on the link
for a particular revision and then clicking on the blue plus icon that
appears when you hover over a line. Anyone have any better suggestions.
Cheers,
Ian
On 6 August 2016 at 06:10, Thilina Manamgoda <ma...@gmail.com> wrote:
> Hi,
>
> Yes it should. What you meant by "Also, I notice in this CWL User Guide (
> http://www.commonwl.org/draft-3/UserGuide.html ) it says the basecommand
> field comes before the input and output parameters." ?
>
> Thilina.
>
Re: CWL code questions
Posted by Thilina Manamgoda <ma...@gmail.com>.
Hi,
Yes it should. What you meant by "Also, I notice in this CWL User Guide (
http://www.commonwl.org/draft-3/UserGuide.html ) it says the basecommand
field comes before the input and output parameters." ?
Thilina.
Re: CWL code questions
Posted by Gale Naylor <Ga...@noventussolutions.com>.
In CwlContextualView.java, should cwutil be cwlUtil?
Also, I notice in this CWL User Guide (
http://www.commonwl.org/draft-3/UserGuide.html ) it says the basecommand
field comes before the input and output parameters.
Gale
On Fri, Aug 5, 2016 at 10:42 AM Gale Naylor <Ga...@noventussolutions.com>
wrote:
> In CwlContextualView.java (I used the wrong filename in my previous email)
> I'm also curious about the two private, final (but not static) constants
> (?): configurationBean and activity.
>
> I'm not sure this StackOverflow answer is 100% relevant because
> configurationBean and activity do not have initial values, but this is all
> I've been able to find online:
> http://stackoverflow.com/questions/1415955/private-final-static-attribute-vs-private-final-attribute
> .
>
> Can anyone point me to information that would help me understand this
> nomenclature?
>
> Thanks,
>
> Gale
>
> On Fri, Aug 5, 2016 at 10:24 AM Gale Naylor <Ga...@noventussolutions.com>
> wrote:
>
>> I have a couple of additional questions/observations about the CWL code.
>>
>> In CwlContextView.java:
>>
>> - Starting in line 101, is a String called "summery" - I think this may
>> mean "summary". (It looks like the CWL configuration information is being
>> summarized here.)
>>
>> - I'm wondering if in lines 121 and 122 it's permissible to use the
>> DESCRIPTION constant instead of the hard-coded value "description"?
>>
>> Thanks,
>>
>> Gale
>>
>> On Thu, Aug 4, 2016 at 5:56 AM Gale Naylor <Ga...@noventussolutions.com>
>> wrote:
>>
>>> Great!
>>>
>>> Gale
>>>
>>> On Wed, Aug 3, 2016, 9:22 PM Thilina Manamgoda <ma...@gmail.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> Thanks for pointing that out. I have fixed them
>>>> https://github.com/apache/incubator-taverna-common-activities/pull/13
>>>>
>>>> Thanks !
>>>>
>>>> On Thu, Aug 4, 2016 at 12:18 AM, Gale Naylor <
>>>> GaleN@noventussolutions.com>
>>>> wrote:
>>>>
>>>> > I have a couple of questions about the CWL code.
>>>> >
>>>> > (1) In CwlServiceDesc.java, line 50:
>>>> > Should CwlDumyActivity.class be called CwlDummyActivity.class?
>>>> > (Because it looks like the code creates a "dummy" class.)
>>>> >
>>>> > (2) In CwlServiceProvider.java, lines 47 and 48:
>>>> > Should the constant names be upper case? e.g., PROVIDER_NAME and
>>>> > PROVIDER_ID?
>>>> >
>>>> > Thanks!
>>>> > Gale
>>>> >
>>>>
>>>
Re: CWL code questions
Posted by Gale Naylor <Ga...@noventussolutions.com>.
In CwlContextualView.java (I used the wrong filename in my previous email)
I'm also curious about the two private, final (but not static) constants
(?): configurationBean and activity.
I'm not sure this StackOverflow answer is 100% relevant because
configurationBean and activity do not have initial values, but this is all
I've been able to find online:
http://stackoverflow.com/questions/1415955/private-final-static-attribute-vs-private-final-attribute
.
Can anyone point me to information that would help me understand this
nomenclature?
Thanks,
Gale
On Fri, Aug 5, 2016 at 10:24 AM Gale Naylor <Ga...@noventussolutions.com>
wrote:
> I have a couple of additional questions/observations about the CWL code.
>
> In CwlContextView.java:
>
> - Starting in line 101, is a String called "summery" - I think this may
> mean "summary". (It looks like the CWL configuration information is being
> summarized here.)
>
> - I'm wondering if in lines 121 and 122 it's permissible to use the
> DESCRIPTION constant instead of the hard-coded value "description"?
>
> Thanks,
>
> Gale
>
> On Thu, Aug 4, 2016 at 5:56 AM Gale Naylor <Ga...@noventussolutions.com>
> wrote:
>
>> Great!
>>
>> Gale
>>
>> On Wed, Aug 3, 2016, 9:22 PM Thilina Manamgoda <ma...@gmail.com>
>> wrote:
>>
>>> Hi,
>>>
>>> Thanks for pointing that out. I have fixed them
>>> https://github.com/apache/incubator-taverna-common-activities/pull/13
>>>
>>> Thanks !
>>>
>>> On Thu, Aug 4, 2016 at 12:18 AM, Gale Naylor <
>>> GaleN@noventussolutions.com>
>>> wrote:
>>>
>>> > I have a couple of questions about the CWL code.
>>> >
>>> > (1) In CwlServiceDesc.java, line 50:
>>> > Should CwlDumyActivity.class be called CwlDummyActivity.class?
>>> > (Because it looks like the code creates a "dummy" class.)
>>> >
>>> > (2) In CwlServiceProvider.java, lines 47 and 48:
>>> > Should the constant names be upper case? e.g., PROVIDER_NAME and
>>> > PROVIDER_ID?
>>> >
>>> > Thanks!
>>> > Gale
>>> >
>>>
>>
Re: CWL code questions
Posted by Gale Naylor <Ga...@noventussolutions.com>.
I have a couple of additional questions/observations about the CWL code.
In CwlContextView.java:
- Starting in line 101, is a String called "summery" - I think this may
mean "summary". (It looks like the CWL configuration information is being
summarized here.)
- I'm wondering if in lines 121 and 122 it's permissible to use the
DESCRIPTION constant instead of the hard-coded value "description"?
Thanks,
Gale
On Thu, Aug 4, 2016 at 5:56 AM Gale Naylor <Ga...@noventussolutions.com>
wrote:
> Great!
>
> Gale
>
> On Wed, Aug 3, 2016, 9:22 PM Thilina Manamgoda <ma...@gmail.com>
> wrote:
>
>> Hi,
>>
>> Thanks for pointing that out. I have fixed them
>> https://github.com/apache/incubator-taverna-common-activities/pull/13
>>
>> Thanks !
>>
>> On Thu, Aug 4, 2016 at 12:18 AM, Gale Naylor <GaleN@noventussolutions.com
>> >
>> wrote:
>>
>> > I have a couple of questions about the CWL code.
>> >
>> > (1) In CwlServiceDesc.java, line 50:
>> > Should CwlDumyActivity.class be called CwlDummyActivity.class?
>> > (Because it looks like the code creates a "dummy" class.)
>> >
>> > (2) In CwlServiceProvider.java, lines 47 and 48:
>> > Should the constant names be upper case? e.g., PROVIDER_NAME and
>> > PROVIDER_ID?
>> >
>> > Thanks!
>> > Gale
>> >
>>
>
Re: CWL code questions
Posted by Gale Naylor <Ga...@noventussolutions.com>.
Great!
Gale
On Wed, Aug 3, 2016, 9:22 PM Thilina Manamgoda <ma...@gmail.com>
wrote:
> Hi,
>
> Thanks for pointing that out. I have fixed them
> https://github.com/apache/incubator-taverna-common-activities/pull/13
>
> Thanks !
>
> On Thu, Aug 4, 2016 at 12:18 AM, Gale Naylor <Ga...@noventussolutions.com>
> wrote:
>
> > I have a couple of questions about the CWL code.
> >
> > (1) In CwlServiceDesc.java, line 50:
> > Should CwlDumyActivity.class be called CwlDummyActivity.class?
> > (Because it looks like the code creates a "dummy" class.)
> >
> > (2) In CwlServiceProvider.java, lines 47 and 48:
> > Should the constant names be upper case? e.g., PROVIDER_NAME and
> > PROVIDER_ID?
> >
> > Thanks!
> > Gale
> >
>
Re: CWL code questions
Posted by Thilina Manamgoda <ma...@gmail.com>.
Hi,
Thanks for pointing that out. I have fixed them
https://github.com/apache/incubator-taverna-common-activities/pull/13
Thanks !
On Thu, Aug 4, 2016 at 12:18 AM, Gale Naylor <Ga...@noventussolutions.com>
wrote:
> I have a couple of questions about the CWL code.
>
> (1) In CwlServiceDesc.java, line 50:
> Should CwlDumyActivity.class be called CwlDummyActivity.class?
> (Because it looks like the code creates a "dummy" class.)
>
> (2) In CwlServiceProvider.java, lines 47 and 48:
> Should the constant names be upper case? e.g., PROVIDER_NAME and
> PROVIDER_ID?
>
> Thanks!
> Gale
>