You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "hevinhsu (via GitHub)" <gi...@apache.org> on 2025/07/15 05:08:51 UTC
[PR] HDDS-13429. Custom metadata headers with uppercase characters are not supported [ozone]
hevinhsu opened a new pull request, #8805:
URL: https://github.com/apache/ozone/pull/8805
## What changes were proposed in this pull request?
The current [code block in EndpointBase.java](https://github.com/apache/ozone/blob/master/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBase.java#L298-L308) does not correctly handle custom metadata headers when the header names contain uppercase characters.
This may lead to unexpected behavior when clients send headers with capital letters.
Please describe your PR in detail:
* Normalize custom metadata header keys to lowercase at the beginning of processing.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13429
## How was this patch tested?
https://github.com/hevinhsu/ozone/actions/runs/16282548652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13429. Custom metadata headers with uppercase characters are not supported [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on PR #8805:
URL: https://github.com/apache/ozone/pull/8805#issuecomment-3076431773
@ivandika3 Thanks for the review. In the current implementation, Jetty ```ProxyServlet``` does not modify the case of HTTP headers, so the ```toLowerCase()``` logic and related comments no longer exist in [ProxyServer](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/ProxyServer.java).
Jetty’s ```ProxyServlet``` also takes care of hop-by-hop headers and other proxy-related concerns.
All I had to do was implement a [rewriteTarget](https://github.com/apache/ozone/blob/master/hadoop-ozone/integration-test-s3/src/test/java/org/apache/hadoop/ozone/s3/ProxyServer.java#L114) method and address the Expect: 100-continue handling issue in Jetty.
If anything needs clarification or additional changes, feel free to let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13429. Custom metadata headers with uppercase characters are not supported [ozone]
Posted by "Tejaskriya (via GitHub)" <gi...@apache.org>.
Tejaskriya commented on PR #8805:
URL: https://github.com/apache/ozone/pull/8805#issuecomment-3077533966
Thanks for the patch @hevinhsu , and the review @ivandika3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13429. Custom metadata headers with uppercase characters are not supported [ozone]
Posted by "hevinhsu (via GitHub)" <gi...@apache.org>.
hevinhsu commented on PR #8805:
URL: https://github.com/apache/ozone/pull/8805#issuecomment-3077582428
Thank @Tejaskriya, @ivandika3 for the review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-13429. Custom metadata headers with uppercase characters are not supported [ozone]
Posted by "Tejaskriya (via GitHub)" <gi...@apache.org>.
Tejaskriya merged PR #8805:
URL: https://github.com/apache/ozone/pull/8805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org