[GitHub] [mesos] asekretenko commented on a change in pull request #367: Expose hierarchical allocator recovery parameters as master flags

[GitBox <gi...@apache.org>]

asekretenko commented on a change in pull request #367:
URL: https://github.com/apache/mesos/pull/367#discussion_r486441078



##########
File path: src/master/flags.cpp
##########
@@ -460,6 +460,18 @@ mesos::internal::master::Flags::Flags()
       "load an alternate allocator module using `--modules`.",
       DEFAULT_ALLOCATOR);
 
+  add(&Flags::hierarchical_recovery_factor,
+      "hierarchical_recovery_factor",

Review comment:
       `allocator_agent_recovery_factor`? (see my comment on the word  "hierarchical" below)

##########
File path: src/master/allocator/mesos/hierarchical.hpp
##########
@@ -755,6 +755,8 @@ class HierarchicalAllocatorProcess : public MesosAllocatorProcess
 
   // Recovery data.
   Option<int> expectedAgentCount;
+  float agentRecoveryFactor;

Review comment:
       Is it possible to just use these values from `options`? Why keep a copy?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org