You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/02/03 18:36:36 UTC

[GitHub] [lucene] jtibshirani edited a comment on pull request #641: LUCENE-10391: Reuse data structures across HnswGraph#searchLevel calls

jtibshirani edited a comment on pull request #641:
URL: https://github.com/apache/lucene/pull/641#issuecomment-1029284791


   Extracting `HnswGraphSearcher` is a lot nicer, I will push a refactor.
   
   On the topic of hash sets, I tried switching to `IntIntHashMap` on top of this PR and it gives a nice indexing speed-up. I can open a follow-up PR.
   
   About reusing data structures across searches -- I've heard that some other HNSW implementations found this to be beneficial, specifically maintaining a shared pool of "visited" sets for searches to use. It could indeed be complex though, I'd be curious to understand the the magnitude of the improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org