[GitHub] pnowojski commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #6700: [FLINK-10340][table] Add Cosh math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6700#discussion_r220555518
 
 

 ##########
 File path: docs/dev/table/functions.md
 ##########
 @@ -1274,6 +1274,17 @@ ATAN2(numeric1, numeric2)
       </td>
     </tr>
 
+    <tr>
+      <td>
+        {% highlight text %}
+COSH(numeric)
+{% endhighlight %}
+      </td>
+      <td>
+        <p>Returns the hyperbolic cosine of <i>numeric</i>.</p>
 
 Review comment:
   This documentation is desperately missing information about returned types. As it is now, user has no idea that for example all `POWER` invocations, even `POWER(2, 5)` yields **SILENTLY** inaccurate results. Same applies to `COSH(2)`, however in the case of `COSH` this is more or less expected. 
   
   I have filled the ticket regarding the already existing functions https://issues.apache.org/jira/browse/FLINK-10438, but could you add such information here for `COSH`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services